Show test coverage directly after running test#5
Conversation
composer.json
Outdated
There was a problem hiding this comment.
I don't see why this is necessary.
It looks like it was originally added to the main react repository because of HHVM compatibility issues with PHAR, but that should be fixed now: reactphp/reactphp#250 (comment)
Assuming the HHVM compatibility issue is moot, see FriendsOfSymfony/friendsofsymfony.github.io#39 for prior arguments on why I'd be against listing phpunit as a dev dependency.
There was a problem hiding this comment.
After a chat on IRC with @cboden and @clue, they seemt positive, I've made this change to the existing PR. (And the other --coverage-text PR's I've made yesterday.) Pulling it in line with @psychoticmeow's PR's like https://github.com/reactphp/socket-client/pull/8.
In my opinion composer install should install all PHP packages required to develop a package, including phpunit. Not everyone may have it installed, but more likely installs can be outdated and pulling it in likes this ensures everyone has the correct version and can run the tests.
|
After reading the other issues I'm actually -1 on the PHPUnit as a require-dev:
+1 to |
|
Ok cool, will update it Monday when I get back home 👍 |
Show test coverage directly after running test
No description provided.