Clean up test suite and add a functional test case

[clue]

• Clean up test suite
  • Move test helpers to base TestCase
  • Use Composer's autoload-dev
• Add a functional test case

This rather small PR serves as the basis for my other upcoming PRs.

[WyriHaximus]

Any particular reason to place TestCase in the bootstrap rather then it's own file?

[WyriHaximus]

Aside from the TestCase note: LGTM 👍

[clue]

Thanks for your feedback @WyriHaximus, makes sense and has just been resolved! 👍

[jsor]

These 2 methods can be shortened to:

    protected function createPromiseResolved($value = null)
    {
        return Promise\resolve($value);
    }

    protected function createPromiseRejected($value = null)
    {
        return Promise\reject($value);
    }

which makes them kind of obsolete ;)

[WyriHaximus]

@jsor: 👍

[clue]

Agreed, they are of little use, in particular given they're not even used as part of this PR :)

My initial motivation was to support react/promise v1 and v2 alike, but after talking to @jsor, we concluded that it's much cleaner to provide an intermediary v1.1 release to ease transition. Long story short: Let's keep this apart from this PR for now :)

[clue]

after talking to @jsor, we concluded that it's much cleaner to provide an intermediary v1.1 release to ease transition

Just for the reference, this is now being tracked in reactphp/promise#31

[clue]

Thanks for the feedback @jsor and @WyriHaximus, everything's just been resolved 👍

[clue]

Ping @WyriHaximus, @jsor

[jsor]

About the removal of tests/bootstrap.php: @cboden once opened reactphp/promise#17 to allow running the tests when installed as a dependency. Not sure this is still relevant.

[clue]

Not sure this is still relevant.

Personally, I would consider this a non-issue. After all, why would you need to run the tests of your dependencies from within your main project?

Admittedly, I don't really mind either way, let's just move this forward? :-)

Ping @cboden, @WyriHaximus

[WyriHaximus]

Agreed let's more forward 👍

[jsor]

IIRC, this was primarily for running the component tests from the main react/react repository: https://github.com/reactphp/react/blob/master/phpunit.xml.dist#L16

[clue]

Agreed let's more forward 👍

I think we all agree we can move forward either way.

Ping @cboden, what's your take on this?

[cboden]

I do like the ability to run all tests from the main repo. That can be applied in another PR though.