Reduces fwrite() call length to one chunk#147
Merged
clue merged 1 commit intoreactphp:masterfrom Apr 3, 2018
nawarian:fix_test_issue_146
Merged
Reduces fwrite() call length to one chunk#147clue merged 1 commit intoreactphp:masterfrom nawarian:fix_test_issue_146
clue merged 1 commit intoreactphp:masterfrom
nawarian:fix_test_issue_146
Conversation
WyriHaximus
approved these changes
Mar 30, 2018
jsor
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here this PR reduces the string length to be written during the test to one single default chunk in order to avoid blocking calls and as well the
EAGAINerror at MacOS devices.