Throw BadMethodCallException on manual loop creating when required extension isn't installed#153
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Mar 13, 2018
Conversation
Contributor
|
Isn't it better to create |
Member
Author
|
@kaduev13 I would love that, but we're figuring out as a project what and where to place custom exceptions across our packages in the same way. |
Member
Author
clue
approved these changes
Mar 13, 2018
Member
clue
left a comment
There was a problem hiding this comment.
Changes LGTM 👍
Needs to be rebased on current master and commits should be squashed before merging.
Member
Author
jsor
approved these changes
Mar 13, 2018
5a47d01 to
bf2e14b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during our hangouts call today. At the moment when creating a loop directly when the required extension is missing creating will fail epicly. This proposed PR will throw an
BadMethodCallExceptionwhen the required extension is missing.