Add PHPUnit 4.8 to require-dev#69
Merged
clue merged 1 commit intoreactphp:masterfrom Jan 15, 2017
shaunbramley:dev-phpunit-4.8
Merged
Add PHPUnit 4.8 to require-dev#69clue merged 1 commit intoreactphp:masterfrom shaunbramley:dev-phpunit-4.8
clue merged 1 commit intoreactphp:masterfrom
shaunbramley:dev-phpunit-4.8
Conversation
clue
requested changes
Jan 14, 2017
Member
clue
left a comment
There was a problem hiding this comment.
Thanks, can you amend/force-push the fixed indentation? 
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~4.8" | ||
| }, |
Member
There was a problem hiding this comment.
Indentation is a bit off, otherwise LGTM 👍
WyriHaximus
approved these changes
Jan 14, 2017
Member
WyriHaximus
left a comment
There was a problem hiding this comment.
Aside from @clue's comment, LGTM
Author
|
@clue completed as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in reactphp/reactphp#354
Added phpunit 4.8 to require-dev section of composer.json
Modified travisci config to use local phpunit.