Add LimitingServer to limit and keep track of open connections#86
Add LimitingServer to limit and keep track of open connections#86WyriHaximus merged 3 commits intoreactphp:masterfrom
Conversation
|
Updated to work around a legacy PHP 5.3 issue due to old react/event-loop |
|
Out of curiosity: Is |
|
Afaict "accounting" is not a common name for this feature and I'm open for suggestions :-) Afaict, this is not exactly a common feature in the first place, because this is often implemented as part of the underlying "server" instead of via decoration. Given our current design, I would vote to keep this via decoration (e.g. this allows us to limit the number of TLS connections), but I'm not opposed to renaming this feature 👍 FWIW, the name "accounting" is related to "accountant" or "book keeping", which I think is good fit for this feature, because it does more than just "limiting". |
Yeah, i figured after seeing the code, but looked strange just from the name ;) What about |
WyriHaximus
left a comment
There was a problem hiding this comment.
Yes please!
![]()
P.S. When reading into what it does, the name, AccountingServer makes a lot of sense 👍
|
Alright, renamed AccountingServer to LimitingServer, as I think confusion with "managing accounts" is a valid concern 👍 |
Add
LimitingServerto limit number of open connections. This can be useful to limit how many resources are spent on handling connections vs. handling the requests that arrive on each connection (HTTP).Builds on top of #84