Basic comment structure & Github test#2
Merged
kennethreitz merged 2 commits intorealpython:masterfrom Apr 26, 2011
Merged
Conversation
Contributor
|
No worries at all! I'm gladly accepting the contributions. Thanks btw :) To answer your question, yes: typically you'd send a pull request just like this. I just got anxious when I noticed the fork had commits, so I pulled them in myself. So, next time you have another update, send another pull request just like this ✨ |
kennethreitz
pushed a commit
that referenced
this pull request
Apr 26, 2011
Basic comment structure & Github test
kennethreitz
pushed a commit
that referenced
this pull request
Mar 4, 2013
Pulling in the latest changes at origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you pull my code this morning by yourself or did I send a request or do something to push it to your master branch?
I'm still working on learning Github, I've primarily used GIT to manage my solo projects until now.
I am sending this pull request to see how it appears different in my github dashboard graphs and log.
Some minor formatting errors exist, I'll try and fix those once I get the hang of ReStructuredText too, sorry for all the commits I need to get a renderer up locally.