feat(npm): support updating packageManager field and Yarn binary

[ylemkimon]

Changes:

• Set constraints based on the packageManager field, simulating the behavior of Corepack
• Support updating the packageManager field in package.json
  • Update lockfile with the new version
  • Update the Yarn 2+ binary checked in to the repo

Context:

Node v16.9.0+ includes a new tool called Corepack (formerly pmm), to help with managing versions of package managers. It uses the packageManager field in package.json, which is in the form of {yarn,pnpm}@<exact version>.

I've tried to create a new manager, but the logic is too intertwined, e.g., the lockfile depends on the version of the package manager. I agree that the npm manager is too complex and I see a lot of opportunities to refactor, but it'd be out of scope for this PR.

Fixes #11368 if the packageManager is set.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository:

• pnpm 5.18.9 -> 5.18.10: https://github.com/ylemkimon/renovate-corepack/pull/5
• pnpm 5.18.9 -> 6.16.1: https://github.com/ylemkimon/renovate-corepack/pull/7
• Yarn 1.22.11 -> 1.22.15: https://github.com/ylemkimon/renovate-yarn-update/pull/5
• Yarn 2.3.3 -> 2.4.3: https://github.com/ylemkimon/renovate-yarn-3/pull/178
• Yarn 2.3.3 -> 3.0.2: https://github.com/ylemkimon/renovate-yarn-3/pull/181

/cc @arcanis (core maintainer of Yarn and Corepack)

[viceice]

looks good so far, but i like to move the contraints extraction after update phase right before lockfile update binary call is happen

[ylemkimon]

@viceice

i like to move move the contraints extraction after update phase right before lockfile update binary call is happen

Do you mean you'd like to move these

renovate/lib/manager/npm/post-update/yarn.ts

Lines 74 to 77 in 6de8930

	const yarnUpdate = upgrades.find(isYarnUpdate);
	const yarnCompatibility = yarnUpdate
	? yarnUpdate.newValue
	: config.constraints?.yarn;

before generateLockFile() calls?

[viceice]

I'm not sure, in other managers we prefer to extract the contraints in updateArtifacts, but npm manafer is a bit special, so i'm not sure about the right place.

But the place right before the yarn / npm / pnpm call would be the right place

[ylemkimon]

I think refactor can be done in another PR, to reduce complications.

[ylemkimon]

@rarkins Could you let me know what changes are required?

[rarkins]

@ylemkimon I thought you planned to do some refactoring first and then resume this PR?

[ylemkimon]

@rarkins Nope, I was planning to do them after this PR gets merged 😄

[rarkins]

@viceice wdyt?

[viceice]

@rarkins Nope, I was planning to do them after this PR gets merged 😄

LGTM, please don't forget 😉

[renovate-release]

🎉 This PR is included in version 28.21.0 🎉

The release is available on:

• GitHub release
• 28.21.0

Your semantic-release bot 📦🚀