Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Added Option to add Interceptors on Client Level#2118

Merged
alexeyzimarev merged 36 commits intorestsharp:devfrom
bauradar:dev
Sep 13, 2023
Merged

Added Option to add Interceptors on Client Level#2118
alexeyzimarev merged 36 commits intorestsharp:devfrom
bauradar:dev

Conversation

@fseidl-bauradar
Copy link
Contributor

Description

Added Possibility to add Client wide Interceptors, to check Request and Responses on multiple positions

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

fseidl-bauradar and others added 30 commits April 4, 2023 15:11
Removed Console.Test which is not inside Repository
@fseidl-bauradar
Copy link
Contributor Author

fseidl-bauradar commented Sep 19, 2023

Sounds like a good way

@rassilon
Copy link

rassilon commented Nov 2, 2023

@alexeyzimarev , public async Task ThrowExceptionIn_InterceptBeforeRequest_ShouldBeCatchableInTest() {
and:
public async Task ThrowExceptionIn_InterceptAfterRequest_ShouldBeCatchableInTest() {
are both failing for me in my rebased redirection branch. Do these fail for you as well?

EDIT: I think this was due to my question I asked in the follow redirect PR. If after request is called inside the redirection loop then the generated exception gets swallowed by exception -> response translation and throw error on failed request option is off for these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants