-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rclcpp] Add class Waitable #589
Conversation
Provides a virtual API for interacting with wait sets.
02a5ca7
to
908d9a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for a small doubt
if (!wait_set->timers[i]) { | ||
timer_handles_[i].reset(); | ||
} | ||
} | ||
for (size_t i = 0; i < timer_handles_.size(); ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobperron twice on timers? I feel like I'm missing something here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-pasta 😬. Fixed in a4a5493.
@jacobperron one CI run and this guy is good to go. |
Should add |
Thanks, LGTM. |
I believe Windows is failing because those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [rclcpp] Add class Waitable Provides a virtual API for interacting with wait sets. * [rclcpp] Add node interface for Waitables * [rclcpp] Implement node interface for Waitables * [rclcpp] Integrate Waitable entities with executor * Implement remaining logic for integrating Waitables * Add visibility macros and other refactoring to Waitable class * Return zero size for entities in a Waitable by default * Bugfix: Clear list of waitable handles * Bugfix: update Waitable handle list based on readiness * Bugfix: update for loop condition * Give node a node_waitables_ * Give lifecycle node a node_waitables
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
Provides a virtual API for interacting with wait sets.
Closes #588