Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_names_and_types failing on Linux #234

Closed
nuclearsandwich opened this issue Jun 9, 2020 · 4 comments
Closed

test_names_and_types failing on Linux #234

nuclearsandwich opened this issue Jun 9, 2020 · 4 comments
Assignees
@cottsay @ahcorde
Labels
tests

Comments

@nuclearsandwich
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • All platforms
  • Installation type:
    • Source (ci.ros2.org)
  • Version or commit hash:
  • DDS implementation:
    • N/A
  • Client library (if applicable):
    • N/A

Steps to reproduce issue

colcon build --packages-up-to rmw
colcon test --packages-up-to rmw

Expected behavior

Tests on test/test_names_and_types.cpp:131 and test/test_names_and_types.cpp:137 pass.

Actual behavior


13: [ RUN      ] rmw_names_and_types.rmw_names_and_types_fini
13: /home/jenkins-agent/workspace/nightly_linux-aarch64_debug/ws/src/ros2/rmw/rmw/test/test_names_and_types.cpp:131: Failure
13: Expected equality of these values:
13:   rmw_names_and_types_fini(&names_and_types)
13:     Which is: 0
13:   11
13: /home/jenkins-agent/workspace/nightly_linux-aarch64_debug/ws/src/ros2/rmw/rmw/test/test_names_and_types.cpp:137: Failure
13: Expected equality of these values:
13:   rmw_names_and_types_fini(&names_and_types)
13:     Which is: 0
13:   11
13: [  FAILED  ] rmw_names_and_types.rmw_names_and_types_fini (0 ms)

Additional information

I was looking at vcs exact output between today and yesterday and I have no inkling as to why these tests which were passing yesterday are failing today. These should be shot for shot tests of code here and here.
@nuclearsandwich nuclearsandwich self-assigned this Jun 9, 2020
@nuclearsandwich nuclearsandwich mentioned this issue Jun 9, 2020
Merged
@brawner
Copy link
Contributor

brawner commented Jun 9, 2020 •
edited
Loading

I'm actually looking at this exact test right now, and I realized it was not implemented correctly.

Related to this PR
#203

brawner added a commit that referenced this issue Jun 9, 2020
@brawner
Fix rmw_names_and_types_fini test to address issue #234
9a8beb9 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner mentioned this issue Jun 9, 2020
Merged
@brawner
Copy link
Contributor

brawner commented Jun 9, 2020

Addressed in #235

@fujitatomoya
Copy link
Collaborator

I've seen same failure with ros2/ros2@de0a7cf

brawner added a commit that referenced this issue Jun 10, 2020
@brawner
Fix rmw_names_and_types_fini test to address issue #234 (#235)
8bff744 
* Fix rmw_names_and_types_fini test to address issue #234

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Switch explicit size with variable

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* ASSERT_EQ

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@nuclearsandwich
Copy link
Member Author

Closed by #235

jacobperron pushed a commit that referenced this issue Aug 26, 2020
@brawner @jacobperron
Fix rmw_names_and_types_fini test to address issue #234 (#235)
21605aa 
* Fix rmw_names_and_types_fini test to address issue #234

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Switch explicit size with variable

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* ASSERT_EQ

Signed-off-by: Stephen Brawner <brawner@gmail.com>
jacobperron added a commit that referenced this issue Aug 26, 2020
@jacobperron @brawner
Fix rmw_names_and_types_fini test to address issue #234 (#235) (#265)
2d83dfe 
* Fix rmw_names_and_types_fini test to address issue #234

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Switch explicit size with variable

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* ASSERT_EQ

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cottsay cottsay

@ahcorde ahcorde

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nuclearsandwich @brawner @cottsay @ahcorde @fujitatomoya