[foxy backport] Fix rmw_names_and_types_fini test to address issue #234 (#235) #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix rmw_names_and_types_fini test to address issue #234 Signed-off-by: Stephen Brawner <brawner@gmail.com> * Switch explicit size with variable Signed-off-by: Stephen Brawner <brawner@gmail.com> * ASSERT_EQ Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #235 to Foxy.
I'm hoping this fixes the same test failure we're seeing in Foxy, for example:
https://ci.ros2.org/job/ci_linux/12067/testReport/(root)/rmw_names_and_types/rmw_names_and_types_fini/