Support Ruby 2.7.0 #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ruby-syntax-tree/syntax_tree#144, this package is also a dependency of running Prettier for Ruby code on Ubuntu 20.04.
Since @kddnewton was kind enough to add Ruby 2.7.0 support to syntax_tree proper in ruby-syntax-tree/syntax_tree#148, I figured I would try to update syntax_tree-rbs myself. Unfortunately, having little experience with Ruby, my work has proceeded very slowly. I get these errors when running the tests under 2.7.0:
For some reason, the pretty-printing library seems like it's trying to modify one of the string literals that gets passed in from the test fixtures in syntax_tree-rbs, and I haven't been able to figure out why that's happening yet. The tests for prettier_print pass under 2.7.0, so I figure it isn't a problem within that library (or at least it's a bug that isn't known yet).
I'll continue working on this when I have time, but if anyone more familiar with Ruby wants to take a look, it'd probably speed things up.