Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Fix: Handle Fiddle::DLError #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

sevenc-nanashi
Copy link
Contributor

@sevenc-nanashi sevenc-nanashi commented Jan 14, 2023

On Ruby 3.2 and fiddle 1.1.1, this library doesn't work:

c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree/yarv/instruction_sequence.rb:69:in `[]': unknown symbol "rb_iseq_load" (Fiddle::DLError)
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree/yarv/instruction_sequence.rb:69:in `<class:InstructionSequence>'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree/yarv/instruction_sequence.rb:9:in `<module:YARV>'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree/yarv/instruction_sequence.rb:5:in `<module:SyntaxTree>'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree/yarv/instruction_sequence.rb:3:in `<top (required)>'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree.rb:35:in `require_relative'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/syntax_tree-5.2.0/lib/syntax_tree.rb:35:in `<top (required)>'
        from <internal:c:/develop/ruby32/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:160:in `require'
        from <internal:c:/develop/ruby32/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:160:in `rescue in require'
        from <internal:c:/develop/ruby32/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:149:in `require'
        from c:/develop/ruby32/lib/ruby/3.2.0/irb/init.rb:423:in `block in load_modules'
        from c:/develop/ruby32/lib/ruby/3.2.0/irb/init.rb:421:in `each'
        from c:/develop/ruby32/lib/ruby/3.2.0/irb/init.rb:421:in `load_modules'
        from c:/develop/ruby32/lib/ruby/3.2.0/irb/init.rb:21:in `setup'
        from c:/develop/ruby32/lib/ruby/3.2.0/irb.rb:414:in `start'
        from c:/develop/ruby32/lib/ruby/gems/3.2.0/gems/irb-1.6.2/exe/irb:11:in `<top (required)>'
        from c:/develop/ruby32/bin/irb:25:in `load'
        from c:/develop/ruby32/bin/irb:25:in `<main>'

This PR fixes this error.

@kddnewton
Copy link
Member

Interesting! It's working on my machine, but maybe something doesn't get exposed in non-release builds? I'll merge this.

@kddnewton kddnewton merged commit 25e7555 into ruby-syntax-tree:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants