Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

FEATURE: Add --print-width support using extension setting #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

xfalcox
Copy link
Contributor

@xfalcox xfalcox commented Jul 19, 2022

No description provided.

Copy link
Member

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it to match the option so it's consistent, so printWidth for configuration.

xfalcox and others added 3 commits July 19, 2022 14:11
Co-authored-by: Kevin Newton <kddnewton@gmail.com>
Co-authored-by: Kevin Newton <kddnewton@gmail.com>
Co-authored-by: Kevin Newton <kddnewton@gmail.com>
@xfalcox
Copy link
Contributor Author

xfalcox commented Jul 19, 2022

@kddnewton when compiling it locally it's failing to work with

mainThreadExtensionService.ts:111 Activating extension 'ruby-syntax-tree.vscode-syntax-tree' failed: Cannot find module 'semver/functions/parse'
Require stack:
- /home/falco/.vscode-oss/extensions/ruby-syntax-tree.vscode-syntax-tree-0.2.3/node_modules/vscode-languageclient/lib/node/main.js
- /home/falco/.vscode-oss/extensions/ruby-syntax-tree.vscode-syntax-tree-0.2.3/node_modules/vscode-languageclient/node.js
- /home/falco/.vscode-oss/extensions/ruby-syntax-tree.vscode-syntax-tree-0.2.3/out/extension.js
- /usr/lib/code/out/vs/loader.js
- /usr/lib/code/out/bootstrap-amd.js
- /usr/lib/code/out/bootstrap-fork.js.

Have you seen something similar?

@kddnewton
Copy link
Member

@xfalcox nope never seen that. Any chance you need to yarn install again?

@kddnewton kddnewton marked this pull request as ready for review July 19, 2022 17:14
@xfalcox
Copy link
Contributor Author

xfalcox commented Jul 19, 2022

Something with my local setup is messed up, and the packaged VSIX node_modules vscode-languageclient doesn't have it's own node_modules.

Since vsce depends on semver 5.x and vscode-languageclient on 7+, they can't use the shared one and fail to boot. Manually replacing the vsccode-languageclient node_modules with the one I have on dev environment fixes the resulting VSIX package and the extension work.

Well, anyway this isn't related to this PR and the code change here works fine, so it's safe to merge and release on marketplace @kddnewton !

@kddnewton kddnewton merged commit 95dc039 into ruby-syntax-tree:main Jul 19, 2022
@kddnewton
Copy link
Member

@xfalcox out in the marketplace at 0.3.0

@xfalcox xfalcox deleted the print-width-support branch July 19, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants