Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Switch to esbuild. Closes #14. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Conversation

xeger
Copy link
Contributor

@xeger xeger commented Jul 20, 2022

Was easy enough to follow the Microsofft instructions.

Per instructions on the web page, we are compiling the extension and its tests using tsc, but building for distribution using esbuild ... that means we're not testing what we plan to ship!

I tried to use esbuild for the tests and gave up after an hour; that's just not what it's designed for. I also tried to split the duties, compiling tests with tsc and the extension with esbuild; this somewhat works, but it makes things more complicated and I couldn't quite figure out how to suppress TSC's version of the extension & friends.

The hybrid approach is ideal (test what we ship) and could probably be accomplished with more fiddling. For now, I've just given up and added a 2nd job, build to prove that esbuild works, while the ci job has become test and it exclusively uses tsc.

P.S. I notice that I converted all tabs to spaces, in the JSON files I touched. This is VS Code's choice, apparently driven by some local setting. Do you have a preference for JSON in this repo? We should add an .editorconfig and/or a forced setting under .vscode to ensure harmony.

@xeger xeger force-pushed the esbuild branch 3 times, most recently from 038be29 to 1945868 Compare July 22, 2022 05:30
@xeger xeger changed the title Experiment with esbuild. Closes #14. Switch to esbuild. Closes #14. Jul 22, 2022
@kddnewton
Copy link
Member

Shoot, merging the other one makes this conflict. @xeger can you resolve?

@xeger
Copy link
Contributor Author

xeger commented Jul 22, 2022

Done @kddnewton. Note that job names are changing, so you will need to edit required checks for branch protection.

@kddnewton kddnewton merged commit 594538e into ruby-syntax-tree:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants