Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid async race conditions in aput_messages #17754

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

mathematisse
Copy link
Contributor

Description

In some edge cases where aput_messages takes some time, we can create a race condition where we attempt to add messages before the memory has been reset. (I have a custom memory class using async sqlalchemy). This solve the issue by resetting the task memory before any "truly" awaitable functions.

Version Bump?

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I believe this change is already covered by existing unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2025
@logan-markewich logan-markewich merged commit 568de4c into run-llama:main Feb 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants