Avoid async race conditions in aput_messages #17754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some edge cases where aput_messages takes some time, we can create a race condition where we attempt to add messages before the memory has been reset. (I have a custom memory class using async sqlalchemy). This solve the issue by resetting the task memory before any "truly" awaitable functions.
Version Bump?
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
make format; make lint
to appease the lint gods