Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dependencies that are causing import errors #17782

Merged

Conversation

brian-ogrady
Copy link
Contributor

@brian-ogrady brian-ogrady commented Feb 11, 2025

Description

Upon running the embeddings finetuning example notebook in Google colab, a series of import errors appear during execution of the following code finetune_engine.finetune(). The errors are, in order:

  • ImportError Please install 'datasets' to use this function: 'pip install datasets' resulting from fitmixin.py from sentence-transformers
  • ImportError: Using the 'Trainer' with 'PyTorch' requires 'accelerate>=0.26.0': Please run 'pip install transformers [torch]' or 'pip install 'accelerate>=0.26.0^ also resulting from fixmixin.py from sentence-transformers
  • ImportError llama-index-embeddings-huggingface package not found, please run pip install llama-index-embeddings-huggingface resulting from this import statement in embeddings utils

Issue detailed here.

Fixes #17779

Upon adding these dependencies to the pip install statements, the notebook runs without issue.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Tested in new colab notebook and colab notebook locally.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 11, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 11, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) February 11, 2025 04:45
@logan-markewich logan-markewich merged commit 1eaf798 into run-llama:main Feb 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Embedding finetuning example notebook fails because of missing dependencies
2 participants