nicer batch file error when building miri-script fails #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
☀️ Test successful - checks-actions |
This was referenced Jun 27, 2024
bors
added a commit
that referenced
this pull request
Jun 28, 2024
…01, r=RalfJung Fix miri.bat to not exit unconditionally #3703 has a small typo causing it to regress ./miri.bat to not working at all. This PR fixes it. Tested on Windows 11, with stable toolchain missing as well as installed. ```test ./miri toolchain error: toolchain 'stable-x86_64-pc-windows-msvc' is not installed Failed to build miri-script. Is the 'stable' toolchain installed? ``` Closes #3714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3700 (comment)