Fix handling of unmapped configuration options #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaavi
approved these changes
Sep 29, 2022
dhaavi
requested changes
Sep 29, 2022
config/registry.go
Outdated
Comment on lines
125
to
144
| option.activeValue, vErr = validateValue(option, value) | ||
| if vErr != nil { | ||
| return fmt.Errorf("config: invalid value: %w", vErr) | ||
| } |
There was a problem hiding this comment.
Normal config loading just collects the validation errors from loaded config and reports them.
This would prevent the plugin from starting with an invalid config value, if it fails when failing to register the config option.
There was a problem hiding this comment.
after discussion: make sure we can return that error to the caller of config.Register() but not fail the registration
There was a problem hiding this comment.
this requires an update to the plugin system to handle that case correctly
|
One thing that came to my mind, if an option is lazy-registered and the value is poped from the |
eb335ab
to
3ae6368
Compare
63f7a96
to
f67ad49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the configuration system that prevents lazily registered config options to receive the current value stored in the configuration file.
Changes:
replaceConfig) all unmapped/unused values from the configuration file are stored in a globalunmappedValuesmap.config.RegisterOptionchecks for unmapped values from the above map and immediately sets the value of the new option.unmappedValues.