Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Deprecate scala.util.parsing.json #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

janekdb
Copy link
Member

@janekdb janekdb commented Feb 14, 2017

#99

  • Add json package with deprecation comments and link to The Scala Library Index
  • Add deprecation to every top-level class/object in the package

@janekdb
Copy link
Member Author

janekdb commented Feb 14, 2017

@gourlaysama - This is WIP. Please comment on the approach,

  • Add json package with deprecation comments and link to The Scala Library Index
  • Add @deprecation to every member

For now just one member has a deprecation annotation to get early feedback.

Along the way I came across https://issues.scala-lang.org/browse/SI-3115 when I tried to deprecate the package object instead of deprecating every member.

@sjrd
Copy link
Member

sjrd commented Feb 14, 2017

IMO every top-level class/object in the package should be deprecated.

@janekdb
Copy link
Member Author

janekdb commented Feb 14, 2017

@sjrd - Yes, this looks like the very least that should be done.

@janekdb janekdb removed the question label Feb 14, 2017
@gourlaysama
Copy link
Contributor

Yes, please deprecate everything in json/{Lexer,Parser}.scala too.

👍 for the package-level doc that explains things :)

@janekdb janekdb force-pushed the issue/github/99/deprecate-scala.util.parsing.json branch from 63fee67 to 7815fd9 Compare February 14, 2017 17:41
@janekdb
Copy link
Member Author

janekdb commented Feb 14, 2017

All top level entities deprecated.

parsing-json-deprecated

@janekdb janekdb requested a review from sjrd February 14, 2017 17:45
@gourlaysama gourlaysama merged commit d118db9 into scala:1.0.x Feb 14, 2017
@janekdb janekdb deleted the issue/github/99/deprecate-scala.util.parsing.json branch February 15, 2017 14:42
@SethTisue
Copy link
Member

PR'ed to scala/scala for 2.12.3: scala/scala#5880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants