Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add OSGi headers and source bundles. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2013

Conversation

dragos
Copy link
Contributor

@dragos dragos commented Sep 20, 2013

Fixed #1.

@dragos
Copy link
Contributor Author

dragos commented Sep 20, 2013

/cc @jsuereth

@jsuereth
Copy link

LGTM! Thanks for rockin this, Iuli.

@dragos
Copy link
Contributor Author

dragos commented Sep 20, 2013

Thanks! We need a better OSGi version btw. Can sbt-git retrieve the hash of HEAD? I'd like to follow the Scala OSGi version convention for the qualifier.

@jsuereth
Copy link

Yeah. See: https://github.com/sbt/sbt-git/blob/master/src/main/scala/com/typesafe/sbt/SbtGit.scala#L20

You can depend on the result of that setting for the current commit.

adriaanm added a commit that referenced this pull request Sep 26, 2013
Add OSGi headers and source bundles.
@adriaanm adriaanm merged commit e4987d9 into scala:master Sep 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants