Fix #233. Add a new variable lastFailure in Success class.
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anyone watching this repo who could take a stab at reviewing this...? |
|
@Philippus I'm wondering if we ought to just merge this for 1.2.0 and hope for the best |
This change means revival of lastNoSuccessVar(deleted by scala#108). However, in this time, a new variable(`lastFailure` in `Success` class) is immutable(i.e. this variable does not means revival of side effects). That is why, probably, this change does not break referentially transparent.
|
I've rebased the branch on current state of 1.2.x and got a passing build, so I think it's good to merge now. |
|
@Soya-Onishi thank you — it seems your contribution might finally see release :-) |
This was referenced Nov 17, 2020
Closed
SethTisue
pushed a commit
to SethTisue/scala-parser-combinators
that referenced
this pull request
May 13, 2022
fixes scala#233 on 1.1.x branch
SethTisue
pushed a commit
to SethTisue/scala-parser-combinators
that referenced
this pull request
May 13, 2022
fixes scala#233 on 1.1.x branch
SethTisue
pushed a commit
to SethTisue/scala-parser-combinators
that referenced
this pull request
May 13, 2022
fixes scala#233 on 1.1.x branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means revival of lastNoSuccessVar(deleted by #108).
However, in this time, a new variable(
lastFailureinSuccessclass) isimmutable(i.e. this variable does not means revival of side effects).
That is why, probably, this change does not break referentially transparent
Edit: I signed CLA. Sorry for not following the procedure.