Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Use AdoptOpenJDK in the build #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashawley opened this issue Jul 8, 2019 · 3 comments
Closed

Use AdoptOpenJDK in the build #335

ashawley opened this issue Jul 8, 2019 · 3 comments

Comments

@ashawley
Copy link
Member

ashawley commented Jul 8, 2019 •
edited
Loading

@eed3si9n opened #334.

What's the rationale for doing this? Isn't Travis already using OpenJDK?
@eed3si9n
Copy link
Member

eed3si9n commented Jul 8, 2019

What's the rationale for doing this?

Lightbend is unifying on using AdoptOpenJDK distribution of OpenJDK for testing because it's available widely, and it's responsibly maintained. sbt, Akka etc have been doing it a while now, and I am just sweeping through scala/* things.

@SethTisue
Copy link
Member

the change to SDKMAN will hopefully also improve reproducibility, robustness, and up-to-date-ness of the build, since Travis-CI seems to keep changing around what JDKs are supported and also doesn't always keep up with JDK updates

@SethTisue
Copy link
Member

umbrella ticket is scala/scala-dev#587

eed3si9n added a commit to eed3si9n/scala-xml that referenced this issue Jul 10, 2019
@eed3si9n
Use AdoptOpenJDK JDK 8 and 11
d90955e 
Ref scala/scala-dev#587
Fixes scala#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SethTisue @eed3si9n @ashawley