Merged
Conversation
MarvinJWendt
suggested changes
Sep 5, 2020
2 tasks
Contributor
Author
|
I will be fixing this PR and updating it so that it's mergeable. Tracking progress on that in this issue. |
|
Hey @makeworld-the-better-one, I am not working on this repository. I just wanted to point out, that your fork could not be merged because of the changed go.mod file. |
Contributor
Author
|
@schollz This is now ready and can be properly merged. |
Contributor
Author
|
@schollz merge conflicts have been resolved. Can this be merged? Thanks. |
|
@schollz ping if this could get reviewed and merged as it would help with some Debian packaging too. Thank you. |
Owner
|
Sure, it seems good. I guess a test would be useful (though not sure how that would be written) but I'll trust that it works! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ProgressBar.String()method that returns the rendered version of the progress bar as a string. This is useful for environments where one doesn't want to output to stdout, but use the progess bar somewhere else. Personally I'm using it in Amfora, which is a TUI application.This PR also adds the
DefaultSilentandDefaultBytesSilentfuncs, which create aProgressBarthat doesn't output anywhere, and doesn't have