Update sap-cap-capire: add lsp server#53
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis pull request adds LSP (Language Server Protocol) configuration for SAP CAP Capire and updates documentation to reflect the latest versions. A new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/sap-cap-capire/skills/sap-cap-capire/SKILL.md (1)
44-44: Install command documents an optional prerequisite without explaining it's opt-in.Adding
@sap/cds-lspto the default "Install CAP development kit" step will causenpm i -g@sap/cds-lsp`` to run for every new developer setting up a CAP project, even those who never use Claude Code or any other LSP-capable editor. The upstream npm docs themselves state: "The CDS language server can only be used as part of an IDE extension or plugin."Consider moving the LSP install into a dedicated sub-section or marking it optional:
📝 Suggested wording
-# Install CAP development kit -npm i -g `@sap/cds-dk` `@sap/cds-lsp` +# Install CAP development kit +npm i -g `@sap/cds-dk` + +# (Optional) Install CDS Language Server for LSP-capable editors (e.g. Claude Code) +npm i -g `@sap/cds-lsp`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/sap-cap-capire/skills/sap-cap-capire/SKILL.md` at line 44, The install step in SKILL.md currently lists "npm i -g `@sap/cds-lsp`" alongside the CAP development kit, which causes the LSP to be installed by default; update the "Install CAP development kit" step (the section header and its install commands) to remove the cds-lsp line and either create a new optional subsection titled something like "Optional: CDS Language Server (LSP)" or annotate the existing line as opt-in, include a brief note that the CDS language server is only required for IDEs/extensions and link or quote the upstream guidance, and place the "npm i -g `@sap/cds-lsp`" command only inside that new optional subsection or behind the opt-in note.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/sap-cap-capire/skills/sap-cap-capire/SKILL.md`:
- Line 15: Update the frontmatter `lsp_version` entry and the version string in
the version information section to the actual published package version by
replacing `@sap/cds-lsp 9.7.x` with `@sap/cds-lsp 9.2.x`; specifically edit the
`lsp_version` field and the matching version text further down in SKILL.md (look
for the `lsp_version` frontmatter key and the version information block around
the second occurrence).
---
Nitpick comments:
In `@plugins/sap-cap-capire/skills/sap-cap-capire/SKILL.md`:
- Line 44: The install step in SKILL.md currently lists "npm i -g `@sap/cds-lsp`"
alongside the CAP development kit, which causes the LSP to be installed by
default; update the "Install CAP development kit" step (the section header and
its install commands) to remove the cds-lsp line and either create a new
optional subsection titled something like "Optional: CDS Language Server (LSP)"
or annotate the existing line as opt-in, include a brief note that the CDS
language server is only required for IDEs/extensions and link or quote the
upstream guidance, and place the "npm i -g `@sap/cds-lsp`" command only inside
that new optional subsection or behind the opt-in note.
|
Thx thats a good addition! |
Description
Adds the official SAP CDS LSP (@sap/cds-lsp) server to the sap-cap-capire plugin.
LSP integration provides Claude Code with:
Official documentation at: https://code.claude.com/docs/en/plugins-reference#lsp-servers
Type of Change
Checklist
For All PRs
For New Skills
For Skill Enhancements
For Documentation
Related Issues
Testing
Additional Notes
Summary by CodeRabbit
Release Notes
New Features
Documentation