Cloudsofvenus update 1 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…germent Also ensuring subprocess while ensuring a dedicated thread for attacking, proper logging and feedback. While ensuring an improvement of function names and clarity
Also tested on Debian 12 and Testing and Suse enterprise linux but fully tested on these systems. I will provide further updates to ensure everything works as it should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvements are python3 compatibility moving away from an outdated python2 as it is now end of life.
Error handing to ensure graceful disconnections and subprocess creation and http request during attacks.
Proper Resource Management
with statements to ensure proper resource cleaning
ensuring subprocesses are terminated cleanly using os.killpg
Proper threading
using a dedicated thread for attack and flag-based termination and checking if it is alive. :)
Ensured proper logging and feedback that was lacking as this is a proof of concept. One i have been working with for awhile.
Code Smell, better readability and ensuring pep-8 and updated function and variable names for clarity.