Nonkube certs paths refactored #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0a88b0
to
38de6ce
Compare
grs
approved these changes
Nov 14, 2024
lynnemorrison
approved these changes
Nov 14, 2024
c-kruse
approved these changes
Nov 14, 2024
nluaces
approved these changes
Nov 14, 2024
84c4f1e
to
57a2a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the directory trees used to store runtime certificates and by user provided certificates.
Certificate Authorities (issuers) are now stored under:
${HOME}/.local/share/skupper/namespaces/default/runtime/issuers/
${HOME}/.local/share/skupper/namespaces/default/input/issuers/
While client and server certificates are stored under (no more
client/orserver/directory needed):${HOME}/.local/share/skupper/namespaces/default/runtime/certs/
${HOME}/.local/share/skupper/namespaces/default/input/certs/
They need to be kept separate, as in case the namespace resources need to be reloaded, the CAs (issuers)
can be preserved, while the
runtime/certscan be re-generated (or copied frominput/certs).It will also simplify the integration with #1761 .