Add command to star a problem #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skygragon
reviewed
Oct 11, 2016
| if (e) return log.fail(e); | ||
| core.starProblem(problem, function(e) { | ||
| if (e) return log.fail(e); | ||
| log.info(h.prettyText(' Starred', true)); |
There was a problem hiding this comment.
Thanks dude, overall LGTM. Just wondering what if run 'lc star 1' twice, will it be un-starred in the end?
There was a problem hiding this comment.
@skygragon nope, the api is idempotent
There was a problem hiding this comment.
unstar is done by sending a DELETE request to the same endpoint
There was a problem hiding this comment.
OK, I think that is good enough for the moment. I guess there will be more patches to address related functions like 'unstar'. Also want to update local cache whenever is_favor is updated in problem json.
tainenko
pushed a commit
to tainenko/leetcode-cli
that referenced
this pull request
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
lc star 396