Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Support php #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2019
Merged

Support php #163

merged 2 commits into from
Sep 28, 2019

Conversation

poppinlp
Copy link
Contributor

Add supporting for php since leetcode supports it right now.

@sunznx
Copy link

sunznx commented Mar 28, 2019

我用 php 啊,帮忙合并下 - -

@poppinlp
Copy link
Contributor Author

poppinlp commented Apr 9, 2019

@sunznx 这个之前已经在我们 fork 的版本中更新了 https://github.com/leetcode-tools/leetcode-cli
extension 的 language 选择中我稍后加入 php

@skygragon skygragon merged commit 7dd96fc into skygragon:master Sep 28, 2019
@poppinlp
Copy link
Contributor Author

@skygragon Hi.
I'm pretty happy that you get back here. :)
We've forked a repo here some times ago in our org to do some patches. And it's a really important lib for our vscode leetcode plugin.
I think maybe we could get together to maintain a core lib and a CLI lib. That sounds exciting. What do you think about it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants