A temp solution for locked problems. #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skygragon
reviewed
May 16, 2018
| @@ -120,7 +120,7 @@ plugin.getCategoryProblems = function(category, cb) { | |||
| plugin.getProblem = function(problem, cb) { | |||
| log.debug('running leetcode.getProblem'); | |||
| const user = session.getUser(); | |||
| if (problem.locked && !user.paid) return cb('failed to load locked problem!'); | |||
| //if (problem.locked && !user.paid) return cb('failed to load locked problem!'); | |||
There was a problem hiding this comment.
for non-premium user, what's the error now if fetching a locked question?
There was a problem hiding this comment.
It will show "[ERROR] failed to load problem! [0]" when non-premium user try to access locked problem.
|
@skygragon Just tried after updating latest, works with locked problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply disable the user checking and download locked issue directly. works on both premium and normal account.