Closed
Conversation
See the documentation for details. Also changed the documentation accordingly.
toJSONString
this made it necessary to move the source files (again) also added a .gitignore
Closed
Contributor
|
I can't see a pull request this large being approved. You should break out your feature changes into separate pull requests so they are easier to merge and test individually. Also, all previous build tool implementations have been declined. For example, #46, #35, #21. Unless you can show a good reason for implementing it on such a simple project, I can't see it happening. |
Owner
|
Thanks for the offer, but there are no plans at this time for this project to support any build automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the other PR I added the automated build system gradle.
The other changes are you see are either directly related to that (2nd moving of the source files) or the changes I made in the other PR.