Fix All Compiler Warnings#807
Closed
theKnightsOfRohan wants to merge 8 commits intostleary:masterfrom
Closed
Conversation
Owner
|
@theKnightsOfRohan Thanks for the PR. Please limit your changes to the warnings described in the issue. |
Contributor
Author
Sure! Do you want the rest of the changes in a separate PR, or are they unneeded right now? |
Owner
|
Thanks, Hacktoberfest results in a lot of file changes in a short timeframe by people who may not be familiar with the project. It's better to limit the changes during this time. |
Contributor
Author
Done! The short pull request is #808. |
Owner
|
Closing this PR, fix was made in #808 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the compiler comment warnings that were previously present in the project. The warnings were identified during the
gradle buildtask execution.I added or changed javadoc comments to:
Please review the changes and let me know if you have any questions or suggestions.