-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #14
base: main
Are you sure you want to change the base?
Conversation
MostlyKIGuess
commented
Jan 19, 2025
- security fixes
Did you test your changes to be sure nothing breaks with these versions? |
while checking I realized , most of them are not needed, I only kept the necessary ones , will push the commit for that. I saw the mail and updated dependencies, want to fix this before this tuesday. |
- add command-line interface; -include unit test for functionality
Welp the master branch wasn't working, so I made a lot of changes, almost revamping. But shouldn't we just merge the documents of this along with https://sugar-docs-ai.streamlit.app/. But I am willling to update this as well. I just saw the mail regarding dep issues and thought would fix it. |
issue with current master is that ollama and httpx can't be run simultaneity they break each other's dependencies. |
Are you referring to Also @kshitijdshah99 why do we have two ollama dependencies? |
ollama and httpx, check ollama/ollama-python#356 |
Both these dependencies serve different purpose. |
We should just pull from HF instead this way we can remove ollama. What say? |
I'll suggest if @chimosky agrees we can try solving this issue first instead of directly skipping to HuggingFace because then we would have to adjust many code files. |
If we can do without a dependency, then we should. |