fix: Update 'onCaughtError' type inference in 'RenderOptions' to work with React v19 #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f68378e:
|
8f80520 to
94b3245
Compare
|
Type checking failed. 
Solution: fb55/entities#1851 Workaround: Set |
5833132 to
e64d1b8
Compare
aicest
commented
May 28, 2025
e64d1b8 to
f68378e
Compare
eps1lon
approved these changes
May 30, 2025
|
Typechecking is failing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: To fix incorrect
onCaughtErrortype inference inRenderOptions.Repro: https://codesandbox.io/p/devbox/delicate-voice-7wnf7z?file=%2Ftest%2Frender.test-d.ts%3A6%2C5-6%2C28
Why: As explained above.
How: Update TS types.
Checklist:
docs site
- React v18 types: No impact
- React v19 types: Fixed