-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add waveshare pico variants #4129
base: dev
Are you sure you want to change the base?
Conversation
Not sure why test-all failed. |
It's a flaky test that we need to investigate. I've restarted the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add these new targets to the smoke tests in GNUmakefile? That way we ensure these targets will at least continue to compile.
Looks like another flaky test caused this to fail? I implemented your requested changes. Bummed this didnt make the cut for 0.31.0 |
Hello @crypto-smoke thanks for the PR and likewise sorry it did not get in the last release. Furthermore, now that #4215 has been merged into Would it be too much trouble to ask for you to rebase against the latest |
I started looking into this but I recently got a new laptop and haven't quite jumped through the hoops to get the dev environment setup yet. I've set aside my microcontrollers for a bit but when the time comes to get them back out I'll look into updating this PR to align with the current codebase. I appreciate you reaching out! |
Adds board and target files for Waveshare 2040 LoRa and Plus boards.