results: Faster JSON encoding and decoding #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the performance of JSON encoding and decoding of `Results`. Additionally, it fixes a regression introduced in #474 that didn't produce valid JSON for HTTP headers. A test is added that validates the JSON encoding matches the one produced by the `encoding/json`. ``` name old time/op new time/op delta ResultEncodings/json-encode-16 690ns ±12% 297ns ± 0% -56.94% (p=0.000 n=9+9) ResultEncodings/json-decode-16 1.05µs ± 1% 0.03µs ± 1% -97.47% (p=0.000 n=10+8) name old alloc/op new alloc/op delta ResultEncodings/json-encode-16 804B ±87% 0B -100.00% (p=0.000 n=9+10) ResultEncodings/json-decode-16 310B ± 0% 0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ResultEncodings/json-encode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ResultEncodings/json-decode-16 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) ```
golangcibot
reviewed
Mar 24, 2020
| return *(*[]byte)(unsafe.Pointer(&bh)) | ||
| } | ||
|
|
||
| func b2s(z []byte) string { |
| var buf bytes.Buffer | ||
| enc = tc.enc(&buf) | ||
| for _, r := range results { | ||
| enc.Encode(&r) |
There was a problem hiding this comment.
Error return value of enc.Encode is not checked (from errcheck)
| for i := 0; i < b.N; i++ { | ||
| dec.Decode(&results[i%len(results)]) | ||
| dec.Decode(&r) |
There was a problem hiding this comment.
Error return value of dec.Decode is not checked (from errcheck)
tsenart
added a commit
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the performance of JSON encoding and decoding of
Results. Additionally, it fixes a regression introduced in #474 thatdidn't produce valid JSON for HTTP headers. A test is added that
validates the JSON encoding matches the one produced by the
encoding/json.Fixes #505