Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code.less: also set default monospace font for <kbd> and <samp> #9989

Merged
merged 1 commit into from
Sep 11, 2013

Conversation

eins78
Copy link
Contributor

@eins78 eins78 commented Aug 21, 2013

Right now the "default monospace" (as set in variables.less) font is only set on code and pre elements.

It should include at least kbd and samp as well (command is obsolete and var doesn't have to be monospace)

Edit: Updated for clarity

@saas786
Copy link
Contributor

saas786 commented Aug 26, 2013

@eins78 your pull request is invalid, please review normalize.less and you will see its already set to "monospace font".

Ref: https://github.com/twbs/bootstrap/blob/master/less/normalize.less#L161

After review please close this pull request.

@cvrebert
Copy link
Collaborator

@saas786 normalize doesn't use/honor any LESS variables. This does.

@eins78
Copy link
Contributor Author

eins78 commented Aug 26, 2013

Yes, I could have said it more clearly: The configured (as in set as variable in variables.css) monospace font is not used....

@saas786
Copy link
Contributor

saas786 commented Aug 26, 2013

@cvrebert normalize doesn't use/honor any LESS variables. This does.

I am aware of this.

@eins78 Yes, I could have said it more clearly: The configured (as in set as variable in variables.css) monospace font is not used....

Yes, from your initial message I thought you just wanted to have monospace font applied, now I understood you want to have customize able variable based monospace fonts applied to < kbd > & < samp >.

@mdo
Copy link
Member

mdo commented Sep 6, 2013

Why should we style these elements as we do code snippets? Based on my limited reading I don't see a direct correlation.

@eins78
Copy link
Contributor Author

eins78 commented Sep 8, 2013

This is less about "style" and more about consistent typography.
If there is a variable for the monospace font, to me it seems more correct to apply that to all elements which are using a monospace font (either by browser default and/or normalise.less).
Any other styling, as it is done for code snippets, should of course not be applied to these elements – this is just about the font family.

mdo added a commit that referenced this pull request Sep 11, 2013
code.less: also set default monospace font for `<kbd>` and `<samp>`
@mdo mdo merged commit b7e1103 into twbs:master Sep 11, 2013
@mdo mdo mentioned this pull request Sep 11, 2013
@mdo
Copy link
Member

mdo commented Sep 11, 2013

it seems more correct to apply that to all elements which are using a monospace font (either by browser default and/or normalise.less).

Ah, that last part is the kicker—it's the browser default.

Thanks!

stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
code.less: also set default monospace font for `<kbd>` and `<samp>`
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
code.less: also set default monospace font for `<kbd>` and `<samp>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants