-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code.less: also set default monospace font for <kbd>
and <samp>
#9989
Conversation
@eins78 your pull request is invalid, please review normalize.less and you will see its already set to "monospace font". Ref: https://github.com/twbs/bootstrap/blob/master/less/normalize.less#L161 After review please close this pull request. |
@saas786 normalize doesn't use/honor any LESS variables. This does. |
Yes, I could have said it more clearly: The configured (as in set as variable in variables.css) monospace font is not used.... |
@cvrebert normalize doesn't use/honor any LESS variables. This does. I am aware of this. @eins78 Yes, I could have said it more clearly: The configured (as in set as variable in variables.css) monospace font is not used.... Yes, from your initial message I thought you just wanted to have monospace font applied, now I understood you want to have customize able variable based monospace fonts applied to < kbd > & < samp >. |
Why should we style these elements as we do code snippets? Based on my limited reading I don't see a direct correlation. |
This is less about "style" and more about consistent typography. |
code.less: also set default monospace font for `<kbd>` and `<samp>`
Ah, that last part is the kicker—it's the browser default. Thanks! |
code.less: also set default monospace font for `<kbd>` and `<samp>`
code.less: also set default monospace font for `<kbd>` and `<samp>`
Right now the "default monospace" (as set in
variables.less
) font is only set oncode
andpre
elements.It should include at least
kbd
andsamp
as well (command
is obsolete andvar
doesn't have to be monospace)Edit: Updated for clarity