feat(createModel): add selection state layer between registry and selection#148
Open
johnleider wants to merge 1 commit intomasterfrom
Open
feat(createModel): add selection state layer between registry and selection#148johnleider wants to merge 1 commit intomasterfrom
johnleider wants to merge 1 commit intomasterfrom
Conversation
…ection Introduce createModel as the shared selection state foundation that both createSelection and createSlider extend. Refactors createSelection to extend createModel instead of reimplementing selection logic, and generalizes useProxyModel with a structural ProxyModelTarget interface. - Add createModel composable with selectedIds, select/unselect/toggle, mandatory enforcement, and apply bridge for v-model sync - Refactor createSelection to extend createModel (~90 lines removed) - Generalize useProxyModel to accept any ProxyModelTarget - Add documentation page with architecture diagram and live examples - Export createModel from composables barrel
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createModelas the shared selection state foundation betweencreateRegistryandcreateSelection/createSlidercreateSelectionto extendcreateModelinstead of reimplementing selection logic (~90 lines removed)useProxyModelwith a structuralProxyModelTargetinterface, removing hard dependency onSelectionContextArchitecture
createModelprovides:selectedIds,select/unselect/toggle,mandatoryenforcement,disabledguards,applybridge for v-model sync, andreset.Files Changed
composables/createModel/index.tscomposables/createSelection/index.tscomposables/useProxyModel/index.tscomposables/index.tsdocs/pages/composables/selection/create-model.mddocs/examples/composables/create-model/docs/pages/composables/index.mddocs/pages/composables/selection/create-selection.mdTest plan