Open
Conversation
Adds `move(id, toIndex)` to createRegistry, enabling positional reordering of registered items. Rebuilds Map insertion order and triggers reindex with optimized dirty range.
|
commit: |
Add `if (needsReindex) reindex()` at the top of move() to ensure ticket indices are current before the early-return check. Without this, a deferred reindex from a prior unregister() could cause move() to incorrectly skip the operation. Also fixes TSDoc @see URL and proxy registry documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move(id, toIndex)tocreateRegistryfor positional reordering of registered itemsminDirtyIndexContext
Prerequisite for
createDataTablecolumn ordering enhancement — enablescreateRegistry-backed column reorder without fighting append-only semantics.Test plan
pnpm typecheckpasses (both packages/0 and packages/paper)pnpm test:runpasses (3005 tests)pnpm repo:checkpasses (knip + sherif)move()in API table