-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract Plugin Installation From User #4
Conversation
README.md
Outdated
@@ -33,7 +33,7 @@ Zap is a minimal `zsh` plugin manager | |||
## Install | |||
|
|||
```sh | |||
sh <(curl -s https://raw.githubusercontent.com/zap-zsh/zap/master/install.sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org name change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
install.sh
Outdated
@@ -1,6 +1,6 @@ | |||
#!/bin/sh | |||
|
|||
git clone https://github.com/zap-zsh/zap.git "$HOME/.local/share/zap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org name change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
can we try using a lighting bolt instead of a checkmark? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added you to the org btw if interested
Thanks, much appreciated |
Hiding the clone output from users during installation and showing what plugins are being installed instead. (Still refining)