Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T117739

Convert Special:NewPages to OOUI
Closed, ResolvedPublic
Actions

Assigned To
pankajeshkr
Authored By
Florian
Nov 4 2015, 5:23 PM
Tags
Referenced Files
F24361178: image.png
Jul 31 2018, 1:01 PM
F18372987: image.png
May 20 2018, 12:36 PM
F5269541: pasted_file
Jan 10 2017, 11:45 PM
F4492693: pasted_file
Sep 20 2016, 6:46 PM
F4492684: pasted_file
Sep 20 2016, 6:45 PM
F3827546: pasted_file
Apr 4 2016, 12:13 PM
Subscribers
01tonythomas
Aklapper
Florian
Iniquity
Jdforrester-WMF
Ladsgroup
Legoktm
View All 15 Subscribers
Tokens
"Haypence" token, awarded by RandomDSdevel."Party Time" token, awarded by Liuxinyu970226.

Description

Already uses HTMLForm.

BeforeAfter
image.png (728×2 px, 148 KB)
image.png (970×2 px, 121 KB)

Details

SubjectRepoBranchLines +/-
Modified SpecialNewPagemediawiki/coremaster+484 -484
Special:NewPages: Change to use OOUImediawiki/coremaster+37 -20
HTMLForm: Implement OOUI version of HTMLTagFiltermediawiki/coremaster+17 -0
Changed Special_Newpages to use OOuimediawiki/coremaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Florian created this task.Nov 4 2015, 5:23 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added a project: UI-Standardization.
Florian added subscribers: Ricordisamoa, Legoktm, Jdforrester-WMF and 4 others.
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:25 PM
pankajeshkr claimed this task.Mar 12 2016, 9:05 AM
Vishal1796 subscribed.Mar 12 2016, 9:48 AM
gerritbot subscribed.Mar 12 2016, 10:40 AM

Change 276946 had a related patch set uploaded (by Pankajeshkr):
Changed SpecialNewpages to use OOui

https://gerrit.wikimedia.org/r/276946

gerritbot added a project: Patch-For-Review.Mar 12 2016, 10:40 AM
Saurv4u subscribed.Mar 12 2016, 10:43 AM
gerritbot added a comment.Mar 12 2016, 10:45 AM

Change 276947 had a related patch set uploaded (by Pankajeshkr):
Changed Special_Newpages to use OOui

https://gerrit.wikimedia.org/r/276947

pankajeshkr removed pankajeshkr as the assignee of this task.Mar 12 2016, 12:05 PM
pankajeshkr subscribed.
gerritbot added a comment.Mar 14 2016, 12:32 PM

Change 276947 abandoned by Pankajeshkr:
Changed Special_Newpages to use OOui

https://gerrit.wikimedia.org/r/276947

matmarex added a comment.Apr 4 2016, 12:13 PM

pasted_file (539×895 px, 27 KB)

  • The hardcoded wrapper <fieldset> should probably be removed too.
  • There's no OOUI version of HTMLTagFilter.
matmarex merged a task: T145807: Convert Special:NewPages to OOUI.Sep 15 2016, 6:19 PM
matmarex added subscribers: 01tonythomas, TerraCodes.
01tonythomas added a comment.Sep 15 2016, 6:22 PM
In T117739#2177386, @matmarex wrote:

pasted_file (539×895 px, 27 KB)

  • The hardcoded wrapper <fieldset> should probably be removed too.
  • There's no OOUI version of HTMLTagFilter.

matmarex, so this would get only fixed if we have an OOUI version of tag-filter ? Is there a task for that one, or is already done ?

matmarex added a comment.Sep 19 2016, 9:18 PM

Yeah. I don't know of any tasks. It's not done, but it seems fairly easy
– all the pieces are there and they just need to be connected.
ChangeTags::buildTagFilterSelector() already has an option to return
an OOjs UI widget, so HTMLTagFilter just needs to have a
getInputOOUI() method added that would call that and return the widget.

gerritbot added a comment.Sep 20 2016, 6:42 PM

Change 311758 had a related patch set uploaded (by Florianschmidtwelzow):
HTMLForm: Implement OOUI version of HTMLTagFilter

https://gerrit.wikimedia.org/r/311758

Florian added a comment.EditedSep 20 2016, 6:45 PM

pasted_file (447×802 px, 26 KB)

and
pasted_file (530×770 px, 29 KB)

Florian added a comment.Jan 10 2017, 11:45 PM

Ok, the recent version I uploaded changed the changetag filter a bit, so that it suggests the filter, which are currently available, insteaad of requireing the user to type the tag in. However, because of recentchanges in the form, there's one more form element, which does not support OOUI:

pasted_file (561×910 px, 38 KB)

Iniquity subscribed.Jan 10 2017, 11:59 PM
gerritbot added a comment.Sep 10 2017, 12:17 PM

Change 311758 merged by jenkins-bot:
[mediawiki/core@master] HTMLForm: Implement OOUI version of HTMLTagFilter

https://gerrit.wikimedia.org/r/311758

Florian closed this task as Resolved.Sep 17 2017, 8:05 PM
Florian claimed this task.
Ladsgroup subscribed.Sep 17 2017, 8:08 PM

The patch seems for converting to OOUI is not merged yet. Just saying :P

Florian reopened this task as Open.Sep 17 2017, 8:17 PM
Florian removed Florian as the assignee of this task.

Ah damn :D Sorry, just saw my change merged, and I thought I uploaded one to change NewPages, too (as I saw my example image) :P Thanks for pointing to this @Ladsgroup :D

TTO added a subtask: T183765: HTMLSizeFilterField should have an OOUI alternative.Dec 29 2017, 4:37 AM
Volker_E closed subtask T183765: HTMLSizeFilterField should have an OOUI alternative as Resolved.Mar 1 2018, 6:02 PM
matmarex reopened subtask T183765: HTMLSizeFilterField should have an OOUI alternative as Open.Mar 1 2018, 8:30 PM
Volker_E closed subtask T183765: HTMLSizeFilterField should have an OOUI alternative as Resolved.Mar 21 2018, 12:50 AM
gerritbot added a comment.Apr 18 2018, 8:46 AM

Change 276946 had a related patch set uploaded (by VolkerE; owner: Pankajeshkr):
[mediawiki/core@master] Changed Special:NewPages to use OOUI

https://gerrit.wikimedia.org/r/276946

Volker_E updated the task description. (Show Details)May 20 2018, 12:36 PM
matej_suchanek added a project: User-notice.Jul 30 2018, 1:18 PM
gerritbot added a comment.Jul 30 2018, 2:07 PM

Change 276946 merged by jenkins-bot:
[mediawiki/core@master] Special:NewPages: Change to use OOUI

https://gerrit.wikimedia.org/r/276946

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 30 2018, 3:00 PM
Volker_E closed this task as Resolved.EditedJul 31 2018, 12:49 PM
Volker_E assigned this task to pankajeshkr.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Volker_E subscribed.

Thanks @pankajeshkr for the bunch of work here!

Volker_E updated the task description. (Show Details)Jul 31 2018, 1:01 PM
Volker_E removed a subtask: T200659: Special:NewPages: Use an HTMLMultiSelectField instead of text links for filters.
Volker_E mentioned this in T200802: Special:NewPages redundant legend should be visually hidden.Jul 31 2018, 2:43 PM
Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Aug 2 2018, 2:20 PM
Liuxinyu970226 awarded a token.Aug 6 2018, 4:12 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Aug 9 2018, 4:51 PM
RandomDSdevel awarded a token.Oct 1 2018, 1:26 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
gerritbot added a comment.May 4 2023, 9:28 AM

Change 276963 had a related patch set uploaded (by Winston Sung; author: Vishal1796):

[mediawiki/core@master] Modified SpecialNewPage

https://gerrit.wikimedia.org/r/276963

gerritbot added a project: Patch-For-Review.May 4 2023, 9:28 AM

Change 276963 abandoned by Winston Sung:

[mediawiki/core@master] Modified SpecialNewPage

Reason:

Replaced-by: I802d215374c0b5247247dd4ae2facce251e8d369

https://gerrit.wikimedia.org/r/276963

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits