Maniphest T120140

Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when renaming pages or otherwise editing/creating redirects
Closed, ResolvedPublic
Actions

Description

Error

Error when creating a redirect, from T220353#5092493, by @Daimona

message

A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: INSERT INTO `redirect` (rd_from,rd_namespace,rd_title,rd_fragment,rd_interwiki) VALUES ([REDACTED],'0',[REDACTED],[REDACTED],[REDACTED]) ON DUPLICATE KEY UPDATE rd_namespace = '0',rd_title = [REDACTED],rd_fragment = '',rd_interwiki = ''
Function: WikiPage::insertRedirectEntry
Error: 1205 Lock wait timeout exceeded; try restarting transaction

trace

#0 /srv/mediawiki/php-1.33.0-wmf.23/includes/libs/rdbms/database/Database.php(1530): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /srv/mediawiki/php-1.33.0-wmf.23/includes/libs/rdbms/database/Database.php(1248): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /srv/mediawiki/php-1.33.0-wmf.23/includes/libs/rdbms/database/DatabaseMysqlBase.php(1347): Wikimedia\Rdbms\Database->query(string, string)
#3 /srv/mediawiki/php-1.33.0-wmf.23/includes/page/WikiPage.php(1091): Wikimedia\Rdbms\DatabaseMysqlBase->upsert(string, array, array, array, string)
#4 /srv/mediawiki/php-1.33.0-wmf.23/includes/page/WikiPage.php(1464): WikiPage->insertRedirectEntry(Title)
#5 /srv/mediawiki/php-1.33.0-wmf.23/includes/page/WikiPage.php(1423): WikiPage->updateRedirectOn(Wikimedia\Rdbms\DBConnRef, Title, NULL)
#6 /srv/mediawiki/php-1.33.0-wmf.23/includes/Storage/PageUpdater.php(1125): WikiPage->updateRevisionOn(Wikimedia\Rdbms\DBConnRef, Revision, integer)
#7 /srv/mediawiki/php-1.33.0-wmf.23/includes/Storage/PageUpdater.php(758): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
#8 /srv/mediawiki/php-1.33.0-wmf.23/includes/page/WikiPage.php(1916): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#9 /srv/mediawiki/php-1.33.0-wmf.23/includes/EditPage.php(2304): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer, boolean, User, string, array, integer)
#10 /srv/mediawiki/php-1.33.0-wmf.23/includes/EditPage.php(1595): EditPage->internalAttemptSave(array, boolean)
#11 /srv/mediawiki/php-1.33.0-wmf.23/includes/EditPage.php(694): EditPage->attemptSave(array)
#12 /srv/mediawiki/php-1.33.0-wmf.23/includes/actions/EditAction.php(60): EditPage->edit()
#13 /srv/mediawiki/php-1.33.0-wmf.23/includes/actions/SubmitAction.php(38): EditAction->show()
#14 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(501): SubmitAction->show()
#15 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#16 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(867): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(517): MediaWiki->main()
#18 /srv/mediawiki/php-1.33.0-wmf.23/index.php(42): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): include(string)
#20 {main}

Impact

This can cause the following user scenarios to fail:

Renaming a page, which as part of its logic needs to create a redirect. Previously: T163597: Fatal error "Lock wait timeout exceeded" from WikiPage::insertRedirectEntry when moving a page.
Creating a new redirect article for an alternate name. Previously: T220353: Unable to create redirect on dewiki - fatal DBQueryError.
Editing an existing redirect to point elsewhere, e.g. article alias, or template shortcut.

Original task description by @Banjo

Template page https://gl.wikipedia.org/wiki/Modelo:ZWEb was overwritten with another redirect template that was pointing to it. We cannot undo the self-redirect now, any edit/move/delete attempt results in below error:

A database query error has occurred. This may indicate a bug in the software.

Function: WikiPage::insertRedirectEntry
Error: 1205 Lock wait timeout exceeded; try restarting transaction (10.64.16.27)

Page history: https://gl.wikipedia.org/w/index.php?title=Modelo:ZWEb&action=history

Details

	Subject	Repo	Branch	Lines +/-
	Reduce delete attempts on redirect table for move and page creation	mediawiki/core	master	+4 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T30499 [DO NOT USE] 1205: Lock wait timeout exceeded; try restarting transaction (tracking)
		Resolved		Umherirrender	T120140 Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when renaming pages or otherwise editing/creating redirects

Event Timeline

Banjo created this task.Dec 2 2015, 10:39 PM

Banjo raised the priority of this task from to Needs Triage.

Banjo updated the task description. (Show Details)

Banjo added a project: MediaWiki-Parser-Templates.

Banjo subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 2 2015, 10:39 PM

This is… surprising, and not good.

Jdforrester-WMF added a project: MediaWiki-Redirects.Dec 2 2015, 10:44 PM

Jdforrester-WMF set Security to None.

fixed it, I had to do the following:

Merge history of https://gl.wikipedia.org/wiki/Modelo:ZWEb to https://gl.wikipedia.org/wiki/Modelo:ZIMb
Edit https://gl.wikipedia.org/wiki/Modelo:ZIMb removing the redirect text
Moving https://gl.wikipedia.org/wiki/Modelo:ZIMb to https://gl.wikipedia.org/wiki/Modelo:ZWEb

No actions needed on our side, this should sort it out. Let me know if you need further details for any tests or further investigation you want to perform.

Jackmcbarn renamed this task from Template page with self redirect cannot be edited to Lock wait timeout exceeded when editing a self-redirecting template.Dec 4 2015, 3:14 AM

Jackmcbarn added a project: MediaWiki-libs-Rdbms.

aaron merged a task: Restricted Task.Dec 8 2015, 11:04 PM

aaron added subscribers: aaron, Bawolff, Hanay and 2 others.

Lock wait timout DB errors happening involving self-redirects https://logstash.wikimedia.org/#dashboard/temp/AVGHw67XptxhN1Xaw2uo

Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.May 8 2017, 1:34 AM

Krinkle removed a project: MediaWiki-Redirects.Jul 31 2017, 9:18 PM

Krinkle renamed this task from Lock wait timeout exceeded when editing a self-redirecting template to Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when editing a self-redirecting template.Aug 4 2018, 4:52 PM

Krinkle added a project: Wikimedia-production-error.

Krinkle added a parent task: T30499: [DO NOT USE] 1205: Lock wait timeout exceeded; try restarting transaction (tracking).Aug 4 2018, 4:54 PM

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Older on the Wikimedia-production-error board.Sep 18 2018, 8:09 PM

Still seen on 1.32.0-wmf.24.

Query: INSERT INTO `redirect` (rd_from,rd_namespace,rd_title,rd_fragment,rd_interwiki) VALUES ('#######','3','###','','') ON DUPLICATE KEY UPDATE rd_namespace = '3',rd_title = '###',rd_fragment = '',rd_interwiki = ''
Function: WikiPage::insertRedirectEntry
Error: 1205 Lock wait timeout exceeded; try restarting transaction


Exception executing job: LocalPageMoveJob LocalRenameUserJob from=#### new=[3,"###"] old=[3,"####"] renamer=##### requestId=W7ZqqgrAADQAAGD8BUoAAAAN session={"headers":"array(...)","ip":"########","sessionId":"","userId":0} suppressredirects= to=### : 

Wikimedia\Rdbms\DBQueryError: A database query error has occurred.

trace

#2 /srv/mediawiki/php-1.32.0-wmf.24/includes/libs/rdbms/database/DatabaseMysqlBase.php(1367): Wikimedia\Rdbms\Database->query(string, string)
#3 /srv/mediawiki/php-1.32.0-wmf.24/includes/page/WikiPage.php(1057): Wikimedia\Rdbms\DatabaseMysqlBase->upsert(string, array, array, array, string)
#4 /srv/mediawiki/php-1.32.0-wmf.24/includes/page/WikiPage.php(1430): WikiPage->insertRedirectEntry(Title)
#5 /srv/mediawiki/php-1.32.0-wmf.24/includes/page/WikiPage.php(1389): WikiPage->updateRedirectOn(Wikimedia\Rdbms\DatabaseMysqli, Title, NULL)
#6 /srv/mediawiki/php-1.32.0-wmf.24/includes/MovePage.php(589): WikiPage->updateRevisionOn(Wikimedia\Rdbms\DatabaseMysqli, Revision, integer)
#7 /srv/mediawiki/php-1.32.0-wmf.24/includes/MovePage.php(271): MovePage->moveToInternal(User, Title, string, boolean, array)
#8 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CentralAuth/includes/LocalRenameJob/LocalPageMoveJob.php(73): MovePage->move(User, string, boolean)
#9 /srv/mediawiki/php-1.32.0-wmf.24/extensions/CentralAuth/includes/LocalRenameJob/LocalPageMoveJob.php(55): LocalPageMoveJob->movePage(Title, Title)
#10 /srv/mediawiki/php-1.32.0-wmf.24/extensions/EventBus/includes/JobExecutor.php(65): LocalPageMoveJob->run()

Are these jobs that try to also move user subpages?

In T120140#4644077, @aaron wrote:

Are these jobs that try to also move user subpages?

Yes, from what I can tell, the only code that queues a LocalPageMoveJob is another job, namely LocalRenameUserJob. However, they are not nested as far as I can tell. Rather, LocalRenameUserJob pushes instances of LocalPageMoveJob into the queue.

From what I can tell, each LocalPageMoveJob only performs a single page rename. And LocalRenameUserJob itself doesn't perform any edits or page writes (only user and globaluser table interaction).

Krinkle mentioned this in T220353: Unable to create redirect on dewiki - fatal DBQueryError.Apr 8 2019, 6:15 PM

Krinkle edited projects, added Wikimedia-database-issue, MediaWiki-Redirects; removed MediaWiki-libs-Rdbms.Jul 18 2019, 7:50 PM

Krinkle moved this task from General to Database on the MediaWiki-Redirects board.

Krinkle renamed this task from Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when editing a self-redirecting template to Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when renaming pages or otherwise editing/creating redirects.Oct 20 2021, 8:15 PM

Krinkle edited projects, added MediaWiki-Page-rename; removed MediaWiki-Parser-Templates.

Krinkle merged a task: T220353: Unable to create redirect on dewiki - fatal DBQueryError.

Krinkle added subscribers: Markus_Schulenburg, • nnikkhoui, • WDoranWMF and 3 others.

Krinkle updated the task description. (Show Details)Oct 20 2021, 8:20 PM

Krinkle merged a task: T220353: Unable to create redirect on dewiki - fatal DBQueryError.

Krinkle merged a task: T163597: Fatal error "Lock wait timeout exceeded" from WikiPage::insertRedirectEntry when moving a page.

Krinkle added subscribers: Umherirrender, RoySmith, Cirdan and 3 others.

Krinkle added a project: Platform Engineering.Oct 20 2021, 8:22 PM

Krinkle edited projects, added Platform Engineering (Icebox); removed Platform Engineering.

Change 742217 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Reduce delete attempts on redirect table for move and page creation

https://gerrit.wikimedia.org/r/742217

gerritbot added a project: Patch-For-Review.Nov 27 2021, 5:04 PM

Still seen.

As with T220353 and T220353, appears to be disproportionally affecting de.wikipedia.org.

[f79e1c3f-e42c-4efb-a028-8af65a37a7a7] /w/index.php?title=Spezial:Verschieben&action=submit Wikimedia\Rdbms\DBQueryError: Lock wait timeout exceeded; Function: WikiPage::insertRedirectEntry
[32766ec4-8991-41d7-989b-ed98d67bc473] /w/index.php?title=Spezial:Verschieben&action=submit Wikimedia\Rdbms\DBQueryError: Lock wait timeout exceeded; Function: WikiPage::insertRedirectEntry

Change 742217 merged by jenkins-bot:

[mediawiki/core@master] Reduce delete attempts on redirect table for move and page creation

https://gerrit.wikimedia.org/r/742217

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2022, 5:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 7 2022, 6:00 PM

Krinkle mentioned this in T226898: Database error while moving over redirect: Transaction exceeding the limit of 3 seconds (via Special:MovePage).Apr 9 2022, 8:47 PM

In T120140#7803875, @Krinkle wrote:

Still seen.

As with T220353 and T220353, appears to be disproportionally affecting de.wikipedia.org.

[f79e1c3f-e42c-4efb-a028-8af65a37a7a7] /w/index.php?title=Spezial:Verschieben&action=submit Wikimedia\Rdbms\DBQueryError: Lock wait timeout exceeded; Function: WikiPage::insertRedirectEntry

[32766ec4-8991-41d7-989b-ed98d67bc473] /w/index.php?title=Spezial:Verschieben&action=submit Wikimedia\Rdbms\DBQueryError: Lock wait timeout exceeded; Function: WikiPage::insertRedirectEntry

Hopefully since the deployment of wmf.7 this should no longer be an issue (but other issues with page moves still exists)

Umherirrender mentioned this in T320568: DBQueryError for page move on dewiki (october 2022).Oct 11 2022, 7:35 PM

Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when renaming pages or otherwise editing/creating redirectsClosed, ResolvedPublicActions