Maniphest T121189

On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Dec 11 2015, 3:28 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Somewhat interferes with my ability to assess T120966: On single edit tab wikis, clicking on a section edit link gives an editor whose switching works oddly. :-(

Details

	Subject	Repo	Branch	Lines +/-
	Check that we really want VE before loading it for section edits	mediawiki/extensions/VisualEditor	master	+12 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T265163 Create a system to encode best practices into editing experiences
		Open		Trizek-WMF	T331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
		Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
		Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
		Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
		Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
		Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
		Resolved		Krenair	T55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
		Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
		Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
		Resolved		Krenair	T89060 VisualEditor is not the editor linked from the diff page
		Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
		Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor
		Open		None	T54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
		Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
		Resolved		Krenair	T54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
		Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
		Resolved		Krenair	T121189 On single edit tab wikis, clicking on a section edit link always gives the visual editor regardless of visualeditor-editor setting

Event Timeline

Jdforrester-WMF created this task.Dec 11 2015, 3:28 AM

Jdforrester-WMF assigned this task to Krenair.

Jdforrester-WMF raised the priority of this task from to High.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF added subscribers: Aklapper, Krenair.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 11 2015, 7:01 PM

Change 258635 had a related patch set uploaded (by Alex Monk):
Check that we really want VE before loading it for section edits

https://gerrit.wikimedia.org/r/258635

gerritbot added a project: Patch-For-Review.Dec 11 2015, 11:17 PM

Change 258635 merged by jenkins-bot:
Check that we really want VE before loading it for section edits

https://gerrit.wikimedia.org/r/258635

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 12 2015, 12:00 AM

Looks to be fixed. Thanks!