Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | Feature | None | T40450 Reimplement MediaWiki's info action (tracking) | ||
Declined | None | T43326 Incorporate analytics into MediaWiki's info action | |||
Resolved | Tgr | T43327 Add page views graph(s) to MediaWiki's info action for Wikimedia wikis | |||
Resolved | Tgr | T125917 Deploy the PageViewInfo extension to production | |||
Resolved | • dpatrick | T123592 Security review for WikimediaPageViewInfo extension | |||
Resolved | Legoktm | T125919 Finish the first version of the WikimediaPageViewInfo extension | |||
Resolved | Tgr | T129602 Deploy WikimediaPageViewInfo extension to beta cluster | |||
Resolved | Reedy | T148775 Rename WikimediaPageViewInfo extension to PageViewInfo | |||
Resolved | Peachey88 | T150227 Rename WikimediaPageviewInfo Phabricator project/tag to PageViewInfo | |||
Resolved | Tgr | T158698 PageViewInfo does not work on beta |
Event Timeline
Who wants to own deploying the extension? :) I prefer the people who'll own it to do it but we'll (RelEng) do it if that's not possible, of course.
Actually if @Addshore is going to become a SWAT deployer, he could own deploying this and I'll just assist :)
Lack of time on my part to push this, as well as issues deploying to beta cluster (no pageview API in beta): T129602: Deploy WikimediaPageViewInfo extension to beta cluster.
This is not particularly urgent and we try to minimize changes during the fundraiser / holidays / conference combo. I'll do the deployment some time mid-January.
@Jdforrester-WMF @Legoktm @greg @Nuria barring objections I'd like to deploy this in about two week's time. (The extension has been on beta for a while but a set of patches that substantially rewrites it has just been merged.)
Both the graph shown on the info action and the new API endpoints use ObjectCache, so I guess deploy plan is to follow the train, and watch fatalmonitor and the pageview API and memcached health graphs.
Links: fatalmonitor, pageviews API load, memcached load, memcached errors, PageViewInfo logs.
Cache key format: <wiki>:pvi::[30|]:[view|unique]:[article|top|site][:<md5(title)>].
I tried checking this out on Beta Cluster, but it doesn't seem to be working. In the page information, every page says:
Page views in the past 30 days 0
And if you try to click on the zero link, it does nothing. Even the Main Pages say 0 page views.
@kaldari clicks not working will be fixed by https://gerrit.wikimedia.org/r/#/c/338702/. I'll look into why fetching the data fails.
Change 342694 merged by jenkins-bot:
[mediawiki/tools/release] Add PageViewInfo to make-wmf-branch/config.json
Deploy steps for group0:
- update make-wmf-branch script https://gerrit.wikimedia.org/r/#/c/342694/
- add PageViewInfo submodule to 1.29.0-wmf.15: merge https://gerrit.wikimedia.org/r/#/c/342745/ and pull it to the deployment host
- add PageViewInfo submodule to 1.29.0-wmf.16: merge https://gerrit.wikimedia.org/r/#/c/342747/ and pull it to the deployment host
- set up l10n etc: merge & pull https://gerrit.wikimedia.org/r/#/c/342683 and run scap sync
- enable on group0: merge & pull https://gerrit.wikimedia.org/r/#/c/342728 and run scap sync-file wmf-config/InitialiseSettings.php
Change 342683 merged by Gergő Tisza:
[operations/mediawiki-config] Deploy PageViewInfo to testwiki
Mentioned in SAL (#wikimedia-operations) [2017-03-14T22:42:24Z] <tgr@tin> Started scap: T125917: Deploy PageViewInfo to testwiki
Mentioned in SAL (#wikimedia-operations) [2017-03-14T23:31:23Z] <tgr@tin> Finished scap: T125917: Deploy PageViewInfo to testwiki (duration: 48m 58s)
"PageViewInfo" is now listed at https://test.wikipedia.org/wiki/Special:Version. But when I visit a page such as https://test.wikipedia.org/w/index.php?title=Main_Page&action=info, I don't see a graph.
Change 342728 merged by jenkins-bot:
[operations/mediawiki-config] Deploy PageViewInfo to group0
Mentioned in SAL (#wikimedia-operations) [2017-03-15T18:21:36Z] <legoktm@tin> Synchronized wmf-config/InitialiseSettings.php: Deploy PageViewInfo to group0 - T125917 (duration: 00m 42s)
Change 342684 merged by jenkins-bot:
[operations/mediawiki-config] Deploy PageViewInfo to group1
Mentioned in SAL (#wikimedia-operations) [2017-03-15T23:12:00Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:342684|Deploy PageViewInfo to group1]] T125917 (duration: 00m 43s)
User notice: monthly page views will be available (once the train is over) by clicking the "Page information" link in the sidebar.
Developer notice: also from the API (siteviews, mostviewed, pageviews API modules)
@Tgr Just making very clear, this will be on all Wikimedia wikis once the train is over?
Yes. Technically not connected to the train, but uses the same schedule (it's on group0 & group1 now, will go out to Wikipedias tomorrow).
I'm missing some images...
Take https://commons.wikimedia.org/w/index.php?title=File:Flore_d%27Egypte_(8265988245).jpg&action=info
https://commons.wikimedia.org/api/rest_v1/page/graph/png/File%3AFlore_d%27Egypte_%288265988245%29.jpg/0/e52340a02c1e4ba186ffcc37dc04c26600acf3be.png
https://commons.wikimedia.org/api/rest_v1/page/graph/png/File%3AFlore_d%27Egypte_%288265988245%29.jpg/0/42ed6d331cb2b3ee17a53ac8cb0ee459ab790c6e.png
These images are broken for me.
Same on https://commons.wikimedia.org/w/index.php?title=File:01586jfEast_West_Tapinac_Bataan_Olongapo_Proper_Road_Zambalesfvf_11.JPG&action=info
https://commons.wikimedia.org/api/rest_v1/page/graph/png/File%3A01586jfEast_West_Tapinac_Bataan_Olongapo_Proper_Road_Zambalesfvf_11.JPG/0/c2770f4e10258815bf487e144dd6bea3bc91b668.png
Produces 400's with something like:
{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/unknown_error","method":"get","uri":"/commons.wikimedia.org/v1/page/graph/png/File%3ADe_Hohestaufen_(Ammerm%C3%83%C2%BCller)_104.jpg/0/62f5bfc4bcfbd84800094c585fd7afdb6c9baf4d.png"}
That's unrelated, the PageViewInfo graph is the one that opens when you click on the pageview count. (Which probably should not be 0, but that's a problem with the Pageviews API, not the extension.)
Change 342685 merged by jenkins-bot:
[operations/mediawiki-config] Deploy PageViewInfo to group2
Mentioned in SAL (#wikimedia-operations) [2017-03-16T23:25:14Z] <reedy@tin> Synchronized wmf-config/InitialiseSettings.php: Enable PageViewInfo to group2 T125917 (duration: 00m 49s)
The extension has been on all wikis for the weekend, with no errors (other than a few Pageviews API timeouts) and no obvious change to Pageviews API or memcached load, so I'll call this a success.