Add a switch-back-to-WT call-out in VE if coming from switching
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Mar 28 2016, 4:59 PM

Description

Provide the same control as we do in the wikitext editor.

"You have switched to visual editing"
"You can switch back to source editing at any time by clicking on this icon."

Details

	Subject	Repo	Branch	Lines +/-
	Add a popup after switching into VE from WTE	mediawiki/extensions/VisualEditor	master	+75 -18

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T265163 Create a system to encode best practices into editing experiences
Open		Trizek-WMF	T331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
Resolved		• AlexMonk-WMF	T131066 Add a switch-back-to-WT call-out in VE if coming from switching

Event Timeline

Jdforrester-WMF created this task.Mar 28 2016, 4:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2016, 4:59 PM

Like an education popup on the switch button?

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Mar 29 2016, 1:25 AM

Jdforrester-WMF added a parent task: T131130: Enable single edit tab on enwiki and review.

In T131066#2156433, @AlexMonk-WMF wrote:

Like an education popup on the switch button?

With different behaviour; shown always if not seen before and the user switched into this edit. Will need to deal with the other pop-ups (edit notices) I'm afraid.

In T131066#2157922, @Jdforrester-WMF wrote:

With different behaviour; shown always if not seen before and

Aren't the education popups shown if not seen before? What's different with the "always" here?

In T131066#2157922, @Jdforrester-WMF wrote:

Will need to deal with the other pop-ups (edit notices) I'm afraid.

Meaning that if we open another one, this popup has to disappear?

In T131066#2159787, @AlexMonk-WMF wrote:

In T131066#2157922, @Jdforrester-WMF wrote:

With different behaviour; shown always if not seen before and

Aren't the education popups shown if not seen before? What's different with the "always" here?

The blue dots are shown. The pop-ups themselves aren't. This isn't a blue dot, but an immediate pull-out (the same way it works in WT, and the same way that edit notices work in VE).

In T131066#2157922, @Jdforrester-WMF wrote:

Will need to deal with the other pop-ups (edit notices) I'm afraid.

Meaning that if we open another one, this popup has to disappear?

Yeah. Sorry for the mess.

Jdforrester-WMF added a parent task: T128478: Enable single edit tab on enwiki.Mar 31 2016, 9:06 AM

Jdforrester-WMF removed a parent task: T131130: Enable single edit tab on enwiki and review.

In T131066#2164184, @Jdforrester-WMF wrote:

the same way that edit notices work

Oh yeah, that hack. It'll work for this, but:

In T131066#2157922, @Jdforrester-WMF wrote:

Will need to deal with the other pop-ups (edit notices) I'm afraid.

Meaning that if we open another one, this popup has to disappear?

Yeah. Sorry for the mess.

We'll need to figure out what to do when we want to show both edit notices and this.

• Elitre subscribed.Apr 6 2016, 7:17 AM

<Krenair> When you open VE, it can open both the edit notices popup and this new popup
<James_F> Yeah.
<Krenair> but we don't want to show both at the same time
<Krenair> so which one gets priority?
<James_F> This one.
<Krenair> I suppose suppressing edit notices in this case isn't so bad as the user presumably just saw them on the wikitext editor