Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T179844

Indicate that constraint check results are potentially stale
Closed, ResolvedPublic
Actions

Description

Constraint check results can sometimes be stale – this is already the case, due to the query service’s cache (causing T170672: Constraints gadget continues to show a resolved unique value violation for a while after a merge), but will become even worse once we implement proper constraint result caching (T179839). We should indicate this in the API response, and the gadget should alert the user to it (gently).

Patch-For-Review:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 6 2017, 5:40 PM
Lucas_Werkmeister_WMDE mentioned this in T179849: Cache all constraint check results per-entity.Nov 6 2017, 5:54 PM
Lucas_Werkmeister_WMDE claimed this task.Nov 7 2017, 12:17 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2017-11-07.Nov 7 2017, 1:11 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-11-07 board.
gerritbot subscribed.Nov 7 2017, 6:29 PM

Change 389774 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add staleness indication to CheckResult and API

https://gerrit.wikimedia.org/r/389774

gerritbot added a project: Patch-For-Review.Nov 7 2017, 6:30 PM

Change 389775 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ancillary messages to ConstraintReportPanel

https://gerrit.wikimedia.org/r/389775

gerritbot added a comment.Nov 7 2017, 6:30 PM

Change 389776 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ancillary message for stale results to gadget

https://gerrit.wikimedia.org/r/389776

Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Nov 7 2017, 6:30 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2017-11-07 board.Nov 8 2017, 10:52 AM
• Jonas updated the task description. (Show Details)Nov 9 2017, 1:13 PM
gerritbot added a comment.Nov 9 2017, 5:56 PM

Change 390281 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Propagate whether query result was cached

https://gerrit.wikimedia.org/r/390281

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 9 2017, 5:56 PM
gerritbot added a comment.Nov 10 2017, 12:00 PM

Change 390395 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add maximum age to CachedResult

https://gerrit.wikimedia.org/r/390395

Lucas_Werkmeister_WMDE moved this task from Review to In Progress on the Wikidata-Sprint-2017-11-07 board.Nov 14 2017, 12:33 PM
Lucas_Werkmeister_WMDE moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE added a comment.EditedNov 14 2017, 12:39 PM

Okay, after discussion with @thiemowmde, the new implementation plan is:

  • Add a CachingMetadata value object that holds the max-age and possibly additional information in the future. It also has a static constructor to merge several CachingMetadata objects into a new one.
  • Add a CachedBoolean class and a CachedArray class which wrap a value and some CachingMetadata. Make the helpers return those.
  • A CheckResult can optionally hold a single CachingMetadata object, with a simple getter/setter interface.

And here’s how I would split that up across commits:

  1. add CachingMetadata + test (and we might as well start with a max-age right away, no need to keep that in a separate change)
  2. add CachedArray, subclass CachedQueryResults, use in runQuery()
  3. add CachedBoolean, use in SparqlHelper+TypeCheckerHelper
  4. add CachingMetadata to CheckResult and API response
    • question: should the CachingMetadata know how to serialize itself to an array for the API response, or does this logic live in the API?
  5. add ancillary message to gadget (not sure if this commit even needs any changes apart from a rebase… but I suppose yes, if we want to include the unit “seconds” in the max-age field name)
Lucas_Werkmeister_WMDE added a subscriber: thiemowmde.Nov 14 2017, 12:39 PM
gerritbot added a comment.Nov 14 2017, 7:24 PM

Change 391277 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachingMetadata value object

https://gerrit.wikimedia.org/r/391277

gerritbot added a comment.Nov 14 2017, 7:24 PM

Change 391278 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedArray, CachedQueryResults containers

https://gerrit.wikimedia.org/r/391278

gerritbot added a comment.Nov 14 2017, 7:24 PM

Change 391279 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedBool container and use in helpers

https://gerrit.wikimedia.org/r/391279

gerritbot added a comment.Nov 14 2017, 7:24 PM

Change 391280 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedEntityIds container and use in SparqlHelper

https://gerrit.wikimedia.org/r/391280

gerritbot added a comment.Nov 14 2017, 7:24 PM

Change 391281 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachingMetadata to CheckResult and API output

https://gerrit.wikimedia.org/r/391281

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 14 2017, 7:29 PM
gerritbot added a comment.Nov 14 2017, 7:35 PM

Change 389774 abandoned by Lucas Werkmeister (WMDE):
Add CachedResult class and indicate in API response

https://gerrit.wikimedia.org/r/389774

gerritbot added a comment.Nov 14 2017, 7:35 PM

Change 390281 abandoned by Lucas Werkmeister (WMDE):
Propagate whether query result was cached

https://gerrit.wikimedia.org/r/390281

gerritbot added a comment.Nov 14 2017, 7:35 PM

Change 390395 abandoned by Lucas Werkmeister (WMDE):
Add maximum age to CachedResult

https://gerrit.wikimedia.org/r/390395

Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2017-11-07 board.Nov 14 2017, 7:35 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 15 2017, 10:53 AM
gerritbot added a comment.Nov 15 2017, 3:51 PM

Change 391277 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachingMetadata value object

https://gerrit.wikimedia.org/r/391277

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 15 2017, 3:54 PM
gerritbot added a comment.Nov 15 2017, 3:56 PM

Change 391278 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedArray, CachedQueryResults containers

https://gerrit.wikimedia.org/r/391278

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 15 2017, 4:00 PM
gerritbot added a comment.Nov 15 2017, 5:47 PM

Change 391602 had a related patch set uploaded (by Addshore; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.8] Add CachingMetadata value object

https://gerrit.wikimedia.org/r/391602

gerritbot added a comment.Nov 15 2017, 5:47 PM

Change 391603 had a related patch set uploaded (by Addshore; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.8] Add CachedArray, CachedQueryResults containers

https://gerrit.wikimedia.org/r/391603

gerritbot added a comment.Nov 16 2017, 9:52 AM

Change 391602 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.8] Add CachingMetadata value object

https://gerrit.wikimedia.org/r/391602

gerritbot added a comment.Nov 16 2017, 9:52 AM

Change 391603 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.8] Add CachedArray, CachedQueryResults containers

https://gerrit.wikimedia.org/r/391603

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 16 2017, 10:00 AM
gerritbot added a comment.Nov 16 2017, 10:04 AM

Change 391279 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedBool container and use in helpers

https://gerrit.wikimedia.org/r/391279

gerritbot added a comment.Nov 16 2017, 10:23 AM

Change 389775 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ancillary messages to ConstraintReportPanel

https://gerrit.wikimedia.org/r/389775

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)); removed MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 16 2017, 11:00 AM
gerritbot added a comment.Nov 16 2017, 11:08 AM

Change 391280 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedEntityIds container and use in SparqlHelper

https://gerrit.wikimedia.org/r/391280

gerritbot added a comment.Nov 16 2017, 11:12 AM

Change 391281 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachingMetadata to CheckResult and API output

https://gerrit.wikimedia.org/r/391281

gerritbot added a comment.Nov 16 2017, 11:55 AM

Change 391799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Minor fixes to cache code

https://gerrit.wikimedia.org/r/391799

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 16 2017, 11:56 AM
gerritbot added a comment.Nov 16 2017, 12:12 PM

Change 389776 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ancillary message for cached results to gadget

https://gerrit.wikimedia.org/r/389776

gerritbot added a comment.Nov 16 2017, 12:12 PM

Change 391799 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Minor fixes to cache code

https://gerrit.wikimedia.org/r/391799

Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 16 2017, 12:40 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2017-11-07 board.

Done, as far as I can tell.

Lucas_Werkmeister_WMDE moved this task from Doing to Done on the Wikidata-Former-Sprint-Board board.Nov 16 2017, 12:41 PM
Lucas_Werkmeister_WMDE mentioned this in T170672: Constraints gadget continues to show a resolved unique value violation for a while after a merge.Nov 16 2017, 12:44 PM
Lucas_Werkmeister_WMDE mentioned this in T182992: Update 'cached' information when getting constraint check results from cache.Dec 15 2017, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits