Maniphest T202760

UploadWizard: Detail screen stays empty, publishing not possible
Closed, ResolvedPublicAug 31 2018
Actions

Assigned To

Authored By

	Braveheart
	Aug 24 2018, 6:15 PM

Description

Users on de:wp have been reporting an issue with the UploadWizard where the detail screen (last step) stays empty. It is therefore not possible to upload any pictures with the UploadWizard (at least with campaigns).

Link used: https://commons.wikimedia.org/wiki/special:uploadWizard?campaign=wlpa-at-601&id=1680&lat=47.091056&lon=15.4035&descriptionlang=de&description=o.T.+%28Wknr.+115+C%29

The error message in the IE11 console is:

jQuery.Deferred exception: Object doesn't support property or method 'setElementGroup' TypeError: Object doesn't support property or method 'setElementGroup'

at OO.ui.mixin.GroupElement.prototype.insertItem (https://commons.wikimedia.org/w/load.php?debug=false&lang=de&modules=ext.wikimediaEvents%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.lengthLimit%7Cjquery.makeCollapsible.styles%7Cmediawiki.confirmCloseWindow%2Cfeedback%2Chtmlform%7Coojs-ui.styles.icons-editing-core%2Cicons-location&skin=monobook&version=0vn246d:208:824)
at oo.EmitterList.prototype.addItems (Unknown script code:17:917)
at OO.ui.mixin.GroupElement.prototype.addItems (https://commons.wikimedia.org/w/load.php?debug=false&lang=de&modules=ext.wikimediaEvents%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.lengthLimit%7Cjquery.makeCollapsible.styles%7Cmediawiki.confirmCloseWindow%2Cfeedback%2Chtmlform%7Coojs-ui.styles.icons-editing-core%2Cicons-location&skin=monobook&version=0vn246d:208:454)
at UWCategoriesDetailsWidget (ht

Users have reported the same issue with FireFox: https://de.wikipedia.org/wiki/Wikipedia_Diskussion:WikiDaheim#Upload_Wizzard

Details

Due Date: Aug 31 2018, 12:00 AM

	Subject	Repo	Branch	Lines +/-
	Fix category multiwidget with default entries	mediawiki/extensions/UploadWizard	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T204939: UploadWizard: 'Continue' button is not working: "Unable to set property 'licenseMaps' of undefined or null reference"
T202964: Cannot upload photo in campaign: TypeError: item.setElementGroup is not a function

Event Timeline

Braveheart created this task.Aug 24 2018, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2018, 6:15 PM

Herzi.Pinki subscribed.Aug 26 2018, 10:15 AM

we are running a photo competition in Austria (wikidaheim) and we need the automated process for the bloody beginners urgently.

and please add the upload with campaign to the standard regression tests

Same for Polish contest WikiVacations. Reproduction URL

Zrzut ekranu 2018-08-26 19.40.38.png (540×980 px, 72 KB)

Assigning to Matthias for now unless @MarkTraceur wants to take it.

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Aug 27 2018, 12:51 AM

• Ramsey-WMF added a project: Multimedia-Team-Working-Board.

Confirmed in fiwiki's WLM campaing too.

Change 455532 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Fix category multiwidget with default entries

https://gerrit.wikimedia.org/r/455532

gerritbot added a project: Patch-For-Review.Aug 27 2018, 10:04 AM

• AxelPettersson_WMSE subscribed.Aug 27 2018, 1:35 PM

Great work so far. Any chance we can expedite releasing this fix, @MarkTraceur or @matthiasmullie ?

Sylvain_WMFr subscribed.Aug 27 2018, 6:16 PM

Aklapper mentioned this in T202964: Cannot upload photo in campaign: TypeError: item.setElementGroup is not a function.Aug 28 2018, 9:36 AM

Aklapper merged a task: T202964: Cannot upload photo in campaign: TypeError: item.setElementGroup is not a function.

Aklapper added subscribers: intracer, Atsirlin, Romaine and 4 others.

Braveheart added a project: Wiki-Loves-Monuments.Aug 28 2018, 9:41 AM

Antanana awarded a token.Aug 28 2018, 12:17 PM

In T202760#4535533, @Ramsey-WMF wrote:

Great work so far. Any chance we can expedite releasing this fix, @MarkTraceur or @matthiasmullie ?

Saturday is the start of WLM and thus the start of the heaviest trafic to the Upload Campaigns of the year.

Actually, competition already started in Ireland (as well as WikiDaheim in Austria and WikiVacations in Poland). This is rather urgent indeed.

In T202760#4538887, @Effeietsanders wrote:

Actually, competition already started in Ireland. This is rather urgent indeed.

We are directing all uploads through Monumental, so seem to be getting around this issue. However, Monumental is tagging uploads as being part of the 2017 competition, Romaine is currently running bots on the images as a fix for the moment.

• Ramsey-WMF raised the priority of this task from High to Unbreak Now!.Aug 28 2018, 4:09 PM

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptAug 28 2018, 4:09 PM

Change 455532 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Fix category multiwidget with default entries

https://gerrit.wikimedia.org/r/455532

Trizek-WMF added a project: User-notice.Aug 28 2018, 4:40 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 28 2018, 5:00 PM

If MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)) means deployment on Sept. 4th (while WLM starts at Sept. 1st and WikiDaheim is running since the beginning of July) this seems a bit to late. Would it be possible to shift the deployment of this fix to before Sept. 1st? regards

• Thinh68 renamed this task from UploadWizard: Detail screen stays empty, publishing not possible to Thinh6688.Aug 28 2018, 7:23 PM

• Thinh68 claimed this task.

• Thinh68 lowered the priority of this task from Unbreak Now! to High.

• Thinh68 set Due Date to Aug 28 2028, 12:00 AM.

• Thinh68 set the point value for this task to 1000.

• Thinh68 added a subscriber: matthiasmullie.

Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald TranscriptAug 28 2018, 7:23 PM

Ahonc awarded a token.Aug 28 2018, 7:26 PM

Please do deploy it earlier than 4 September. We really need it for Wiki Loves Monuments to be ready on 31 August. All Ukraine's Wiki Loves Monuments list have a direct link to Upload Wizard that currently are not working. If it is absolutely impossible to get them ready by 31 August please give us the planned date so that we inform participants (and remove links that do not work). Thanks

NickK renamed this task from Thinh6688 to UploadWizard: Detail screen stays empty, publishing not possible.Aug 28 2018, 7:30 PM

NickK reassigned this task from • Thinh68 to matthiasmullie.

NickK raised the priority of this task from High to Unbreak Now!.

NickK changed Due Date from Aug 28 2028, 12:00 AM to Aug 31 2018, 12:00 AM.

NickK added a subscriber: • Thinh68.

Aklapper removed the point value for this task.Aug 28 2018, 7:42 PM

Aklapper merged a task: T203022: UploadWizard get frozen in the "Describe" step for all Campaign:whatever .Aug 28 2018, 7:57 PM

Aklapper added a subscriber: SJu.

The bot was wrong, because this got merged so close to the cut; this made it to the train for wmf.19, so is in production now on group0 wikis and will be on Commons tomorrow.

MauricioGenta subscribed.Aug 28 2018, 10:03 PM

Fix has been deployed & it seems to be working just fine again!

Thanks Matthias!

There is an overarching issue here though - this is about the fourth time this year that UploadWizard didn't work partially (or this time, at all). Is there something we can do to make sure that new versions/fixes don't break UploadWizard again? It's quite frustrating to set up a contest with intricate uploadlinks (one very cool feature of UploadWizard) and then for newbies not being able to use it for a week.

Best

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Aug 30 2018, 9:44 PM

Liuxinyu970226 unsubscribed.Aug 31 2018, 12:08 AM