Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T219349

Incorporate better visual layout of contributions page on Minerva, inspired by old design
Open, MediumPublic
Actions

Assigned To
None
Authored By
Jdlrobson
Mar 27 2019, 1:01 AM
Tags
Referenced Files
F42957146: Screenshot 2024-03-21 at 9.32.00 AM.png
Mar 21 2024, 4:32 PM
F42957119: Screenshot 2024-03-21 at 9.31.20 AM.png
Mar 21 2024, 4:32 PM
F34796255: Screen Shot 2021-11-30 at 8.35.47 AM.png
Nov 30 2021, 4:37 PM
F34796249: Screen Shot 2021-11-30 at 8.34.54 AM.png
Nov 30 2021, 4:37 PM
F34796251: Screen Shot 2021-11-30 at 8.35.20 AM.png
Nov 30 2021, 4:37 PM
F34796246: Screen Shot 2021-11-30 at 8.34.06 AM.png
Nov 30 2021, 4:37 PM
Subscribers
Aklapper
• alexhollender_WMF
Jdlrobson
Masumrezarock100
ovasileva
Volker_E

Description

We currently use the desktop HTML for the mobile version of the contributions page.
We should consider updating the Minerva contributions page with some of the good ideas in the previous design. These are:

  • Group by date
  • Show bytes and time to the left for better visual scanning
  • Larger touch areas for links
  • Display of user icon for better recognition about what the page is about.

Screenshots

PagePrevious designExisting design
Contributions
Screen Shot 2021-11-30 at 8.34.06 AM.png (1×942 px, 165 KB)
Screenshot 2024-03-21 at 9.31.20 AM.png (736×990 px, 119 KB)
History
Screen Shot 2021-11-30 at 8.35.20 AM.png (1×942 px, 198 KB)
Screenshot 2024-03-21 at 9.32.00 AM.png (779×1 px, 100 KB)

DEVELOPER NOTES

Styling should occur via a skinStyle defined on the mediawiki.pager.styles module.

There is a problem on Special:Contributions with the invisible ‎ code. It pushes the title down further than it should. I will create a bug, but a patch exists with some discussion.

Details

SubjectRepoBranchLines +/-
WIP: non-AMC special pagesmediawiki/skins/MinervaNeuemaster+388 -7
Recent changes/watchlist/contributions page is styled consistently with mobile pagesmediawiki/skins/MinervaNeuemaster+220 -4
History styles marked as available on mobilemediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 27 2019, 1:01 AM
Jdlrobson added a project: User-Jdlrobson.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Mar 27 2019, 1:02 AM

Change 499268 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] POC: History/contributons page is styled consistently with mobile pages

https://gerrit.wikimedia.org/r/499268

gerritbot added a project: Patch-For-Review.Mar 27 2019, 1:02 AM
Jdlrobson mentioned this in T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.Mar 27 2019, 1:03 AM
Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Mar 27 2019, 10:54 PM
gerritbot added a comment.Mar 28 2019, 5:56 PM

Change 499839 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] History styles marked as available on mobile

https://gerrit.wikimedia.org/r/499839

Jdlrobson moved this task from Backlog to Contributions on the MobileFrontend (MobileFrontend Special Pages) board.Mar 28 2019, 6:42 PM
gerritbot added a comment.Mar 28 2019, 7:20 PM

Change 499839 merged by jenkins-bot:
[mediawiki/core@master] History styles marked as available on mobile

https://gerrit.wikimedia.org/r/499839

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 28 2019, 8:02 PM
gerritbot added a comment.Apr 4 2019, 11:37 PM

Change 499268 abandoned by Jdlrobson:
Recent changes/watchlist/contributions page is styled consistently with mobile pages

https://gerrit.wikimedia.org/r/499268

ovasileva moved this task from Backlog to Existing requests on the Advanced Mobile Contributions board.Jun 18 2019, 11:29 PM
ovasileva moved this task from Existing requests to Backlog on the Advanced Mobile Contributions board.
ovasileva edited parent tasks, added: T198313: [GOAL] Advanced mobile contributions; removed: T216420: [EPIC] Display core version of history page.Jul 2 2019, 9:36 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2019, 10:10 PM
Jdlrobson moved this task from Next up to OKR Backlog on the User-Jdlrobson board.Nov 5 2019, 5:44 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptNov 5 2019, 5:44 PM
Jdlrobson moved this task from Backlog to Triaged on the Advanced Mobile Contributions board.Dec 10 2020, 11:09 PM
Jdlrobson removed a project: Advanced Mobile Contributions.May 25 2021, 6:41 PM
Jdlrobson mentioned this in T133722: Confusing experience on diff/contributions page for admins which has potential for accidental leakage of information.Jun 9 2021, 1:18 AM
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Oct 13 2021, 3:39 PM
Jdlrobson moved this task from Backlog to [active] Remove Special:MobileContributions on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Oct 13 2021, 3:46 PM
gerritbot added a comment.Oct 13 2021, 4:32 PM

Change 730590 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Special:Contributions has list headers

https://gerrit.wikimedia.org/r/730590

gerritbot added a project: Patch-For-Review.Oct 13 2021, 4:32 PM
Umherirrender mentioned this in T121389: Should Special:Contributions be converted to a table.Oct 22 2021, 4:17 PM
Umherirrender subscribed.

There is another approve to display a table - T121389

Jdlrobson added a comment.Oct 22 2021, 4:25 PM

The goal here is to make the page flexible enough to support skins presenting it as they wish. Vector could present this as a table if necessary. This work should help T121389 if anything :)

I should note tables don't map well to the mobile medium without removing information so I'm not sure a table display makes sense unless its desktop resolution only.

gerritbot added a comment.Oct 22 2021, 5:56 PM

Change 733027 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Add list headers to Special:Contributions

https://gerrit.wikimedia.org/r/733027

Umherirrender unsubscribed.Nov 25 2021, 6:48 PM
Volker_E subscribed.Nov 30 2021, 3:34 AM

It would be helpful to have a before and after screenshot in the task description.

Jdlrobson triaged this task as Medium priority.Nov 30 2021, 4:37 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T298581: Mobile version of Special:Contributions leaks existence of globally suppressed users (CVE-2022-28325).Jan 5 2022, 3:53 PM
gerritbot added a comment.Jan 5 2022, 5:30 PM

Change 733027 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: Add list headers to Special:Contributions

Reason:

Proof of concept. Analysis done.

https://gerrit.wikimedia.org/r/733027

Jdlrobson updated the task description. (Show Details)Jan 7 2022, 9:01 PM
ovasileva added a comment.Jan 10 2022, 10:18 AM
In T219349#7536379, @Volker_E wrote:

It would be helpful to have a before and after screenshot in the task description.

@Volker_E - for now, the "after" is expected to be the same as the AMC version. We can make some smaller design changes later on to make sure the page is ready for a wider audience, but not as a part of this task - I'll clarify in the task description

ovasileva updated the task description. (Show Details)Jan 10 2022, 10:18 AM
Jdlrobson renamed this task from Skin Contributions and History pages in Minerva for consistency with their mobile replacements to Skin Contributions page in Minerva for consistency with their mobile replacements.Jan 11 2022, 1:56 AM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jan 19 2022, 12:31 AM

Change 733027 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: Add list headers to Special:Contributions

https://gerrit.wikimedia.org/r/733027

PatchDemoBot added a comment.Jan 26 2022, 1:32 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

PatchDemoBot added a comment.Jan 26 2022, 1:38 AM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d6efd56b19/w/

gerritbot added a comment.Jan 27 2022, 8:21 PM

Change 733027 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: non-AMC special pages

Reason:

Proof of concept. Delaying this work until later when a few other things have been done.

https://gerrit.wikimedia.org/r/733027

Jdlrobson renamed this task from Skin Contributions page in Minerva for consistency with their mobile replacements to Incorporate better visual layout of contributions page on Minerva, inspired by old design.Feb 1 2022, 11:58 PM
Jdlrobson edited projects, added MediaWiki-Special-pages, MinervaNeue; removed Patch-For-Review, MobileFrontend (MobileFrontend Special Pages).
Jdlrobson updated the task description. (Show Details)
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)).

This no longer belongs in technical backlog as it requires design and product input.

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.Feb 2 2022, 2:00 PM
ovasileva added a subscriber: • alexhollender_WMF.
Izno moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Apr 24 2022, 12:41 AM
Jdlrobson moved this task from Current Fiscal Year to Incoming on the Web-Team-Backlog board.Mar 20 2024, 8:57 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.Mar 21 2024, 4:32 PM
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits