⚓ T223303 on production enable bugfix for wbeditentity setting aliases to empty array

	Subject	Repo	Branch	Lines +/-
	Enable feature flag for breaking Wikibase API change	operations/mediawiki-config	master	+2 -0

		Status	Subtype	Assigned	Task
		Resolved		• alaa_wmde	T203337 Fix wbeditentity API ignoring setting aliases to an empty set
		Resolved	Jun 16 2019	WMDE-leszek	T223303 on production enable bugfix for wbeditentity setting aliases to empty array

Michael created this task.May 14 2019, 5:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2019, 5:00 PM

Michael triaged this task as Medium priority.May 14 2019, 5:00 PM

Michael set Due Date to Jun 11 2019, 10:00 PM.

Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald TranscriptMay 14 2019, 5:00 PM

Michael mentioned this in T223305: Remove feature flag for the bugfix for wbeditentity setting aliases to empty array.May 14 2019, 5:08 PM

This can't be done at the given time since most SRE people will be at SRE summit and hence no deployment (no SWAT, no train, no service, literally nothing of course except when production is on fire)

Michael changed Due Date from Jun 11 2019, 10:00 PM to Jun 16 2019, 10:00 PM.Jun 11 2019, 10:52 AM

Michael updated the task description. (Show Details)

Change 516608 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[operations/mediawiki-config@master] Enable feature flag for breaking Wikibase API change

https://gerrit.wikimedia.org/r/516608

gerritbot added a project: Patch-For-Review.Jun 12 2019, 11:04 AM

Michael moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 12 2019, 11:07 AM

Michael moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 13 2019, 8:14 AM

Testing this during SWAT:

ensure that the Wikidata-Sandbox(Q4115189) has aliases for en
run the api-request to setting them to empty: https://www.wikidata.org/wiki/Special:ApiSandbox#action=wbeditentity&format=json&id=Q4115189&data={"aliases"%3A{"en"%3A[]}}
outcome if bugfix successful: aliases for en are removed (easiest to check in the item's history)
outcome if failed: aliases are still there and there is no change in the history

Change 516608 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable feature flag for breaking Wikibase API change

https://gerrit.wikimedia.org/r/516608

https://www.wikidata.org/w/index.php?title=Q4115189&diff=963952400&oldid=963896842

Mentioned in SAL (#wikimedia-operations) [2019-06-17T11:55:19Z] <awight@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit|516608 Enable feature flag for breaking Wikibase API change (T223303)]] (duration: 00m 47s)

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2019, 12:10 PM

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 17 2019, 12:15 PM

WMDE-leszek closed this task as Resolved.Jun 17 2019, 12:58 PM

WMDE-leszek claimed this task.

WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.